Bug 14846 – Layout is not updated when table padding is changed through JavaScript

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Brett Wilson (Google)]

Setting cellPadding on a table in JavaScript has no effect. Cellspacing works.

[Brett Wilson (Google)]

Created attachment 15778 [details]
Testcase

Pressing the cellpadding button which sets cellPadding="25" has no effect on the page.

Pressing the cellspacing button which sets cellSpacing="25" after setting the padding will then update both the padding and the spacing. It seems that setting the padding stores the value, but doesn't cause a layout update. The spacing will force a layout, and the table will look correct.

[Eric Seidel (no email)]

sounds like a missing renderer()->setNeedsLayout(true) call in parseMappedAttribute for the table code.

[Dave Hyatt]

Created attachment 18483 [details]
Make sure to mark cells for layout

[Eric Seidel (no email)]

Comment on attachment 18483 [details]
Make sure to mark cells for layout

I think the fix is great.  Personally I find the name RenderTable:setCellPadding to promote more of  (at least my) historical confusion as to whether it is correct to push attribute changes from the DOM to the Renderer (incorrect) or whether it's right to just mark renderers as needing layout and pull changes from the Renderers from the DOM (correct, and this change does that... in the cells).

Anyway.  Looks fine.

[Dave Hyatt]

Landed in r29539.