Bug 14842 – Patch for DRT that fixes 20+ layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Adam Treat]

Together, this patch fixes some 20+ layout tests in QtWebKit.

bdash mentioned that I shouldn't do refactoring and variable renaming along with real changes.  Unfortunately, I don't have time right now to separate it out and I'm going on vacation till September very soon.

bdash also had problems with the * decorator placement and a stray commented out debug call in LayoutTestController::queueReload.

Perhaps someone else can fix up these changes and commit or I guess I'll do it in September.

Cheers,

Adam

[Adam Treat]

Created attachment 15772 [details]
Fixes DRT

Qt DRT Fix

[Mark Rowe (bdash)]

My comment about * placement was less about this patch than an inconsistency I noticed elsewhere in the Qt-related code while checking whether the non-standard style used in the patch matched that used elsewhere in Qt code.  It does match, but there were a few places in the existing code where the placement is inconsistent.

[Nikolas Zimmermann]

Hey Adam,

+        Modifies the addToJSWindowObject to bind js objects using the built-in
+        kst_window class.  Make sure to protect the created runtime object from
+        garbage collection.

too much KST hacking lately? ;-)

Greetings,
Niko

[Simon Hausmann]

Landed in -r25722

[Holger Freyther]

Comment on attachment 15772 [details]
Fixes DRT

Simon applied this patch, clearing the review flag now.

(In reply to comment #5)
> (From update of attachment 15772 [details] [edit])
> Simon applied this patch

So why is the bug still open?

[George Staikos]

It shouldn't be open.