Bug 14825 - Non-integer hsl() colours are ignored
Summary: Non-integer hsl() colours are ignored
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: data:text/html,<body style="backgroun...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2007-07-31 06:30 PDT by Philip Taylor
Modified: 2007-07-31 11:02 PDT (History)
2 users (show)

See Also:


Attachments
patch (162.55 KB, patch)
2007-07-31 10:48 PDT, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Taylor 2007-07-31 06:30:57 PDT
CSS3 Color says the hue in e.g. hsl(120.0, 100%, 50%) is parsed as a <number>, which I think means it can be a non-integer. Mozilla does accept that colour, but WebKit doesn't.
Comment 1 David Kilzer (:ddkilzer) 2007-07-31 06:41:42 PDT
Verified difference between Firefox 2.0.0.5 (shows green background) and a local debug build of WebKit r24792 with Safari 3 Public Beta v. 3.0.2 (522.12) on Mac OS X 10.4.10 (8R218).  Note that Opera 9.21 does not show a green background, either.
Comment 2 David Storey 2007-07-31 06:58:27 PDT
Opera doesn't support HSL yet.
Comment 3 Sam Weinig 2007-07-31 10:05:01 PDT
This is a very easy fix.  Just righting up a new layout test for this and I should have a patch up in a little bit.
Comment 4 Sam Weinig 2007-07-31 10:48:10 PDT
Created attachment 15760 [details]
patch
Comment 5 mitz 2007-07-31 10:54:59 PDT
Comment on attachment 15760 [details]
patch

r=me
Comment 6 Sam Weinig 2007-07-31 11:01:06 PDT
<rdar://problem/5373922>
Comment 7 Sam Weinig 2007-07-31 11:02:37 PDT
Landed in r24793.