Bug 14766 – S60 browser finditem should be able to find VoIP address

• Status: CLOSED
• Resolution: INVALID
• Component: WebKit Misc.

[George Guo]

According to Find Item UI spec, browser finditem structure should be as follows:
		Phone number
		VoIP address
		E-mail address
		URL address

Browser overrides initialization of Find submenu and does not add option for VoIP address there. 

Refer to JPKN-6X98ZB

[George Guo]

Created attachment 15691 [details]
patch for the solution

[Sachin Padma]

Comment on attachment 15691 [details]
patch for the solution

Please check the ifdef flags. They are not placed correctly

[George Guo]

Created attachment 15743 [details]
New patch

[George Guo]

Created attachment 15751 [details]
patch without ifdef

[Sachin Padma]

Comment on attachment 15751 [details]
patch without ifdef 

in normal scrolling mode numbers should be found. Please check formatting.

[George Guo]

Created attachment 15765 [details]
New patch 

Did the test the scrolling is still working well. Scrolling is using CheckSmartTextEntry and FindItem is using FindNextSmartLink. They won't interfere each other. 

Fixed some historical format issues in WebKitView.cpp as well.

Please review.

[George Guo]

Created attachment 15960 [details]
CR is in defined status, new patch needed

CR 409-415 is in defined status. Patch needed

[Sachin Padma]

Comment on attachment 15960 [details]
CR is in defined status, new patch needed

voip call command is not in browser control commands. Check formatting issues. There are two if statements in webkitcursor.cpp that can be combined when assigning cursor image.

[George Guo]

Created attachment 16210 [details]
New patch after changes based on the previous review

The following changes were made: 
(1) Voip call command was enabled
(2) Two if statements were combined in webkitcursor.cpp 
(3) Format were checked. 
Furthermore the belowing is the test results
* Find phone number still work				pass
* Find Keyword still work				pass
* Find Email address still work 			pass
* Find IP address can find email and phone		pass
* Find VoIP can find 3 digits from 123ok		pass 
* Find VoIP can go back to the beginning at the end	pass 
* Turn on the smart text recoginition work		pass
* After text recogniztion on, do the above tests	pass 



voip call command is not in browser control commands. Check formatting issues.
There are two if statements in webkitcursor.cpp that can be combined when
assigning cursor image.

[Bradley Morrison]

Bulk update of s60 bugs - tagging and closing.

[Bradley Morrison]

Bulk closing of all s60 platform bugs. 

Sorry for the noise!

[Bradley Morrison]

Bulk closing of all s60 platform bugs. 

Sorry for the noise!

[Joel Parks]

re-purposing InTSW keyword for use by QtWebkit team