Bug 14746 – REGRESSION (r21430): Form state not saved for forms that submit via HTTPS even if they do not contain a password field

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

From <http://trac.webkit.org/projects/webkit/changeset/21430>:

-    // Do not save doc state if the page has a password field and a form that would be submitted via https.
+    // Do not save doc state if the page has a form that would be submitted via https.
     Document* document = m_frame->document();
     ASSERT(document);
-    if (document->hasPasswordField() && document->hasSecureForm())
-        return;
         
+    if (document->hasSecureForm())
+         return;

The result is that pages like the one in the URL do not save form state. I do not understand this expansion of the class of documents that do not save state.

[Brady Eidson]

I have a very strong recollection that when I was writing this patch, we discovered that the fact that we *did* save form state for HTTPS was a regression from Safari 2, as many high-security commercial sites refuse to work with your browser if you remember form state at all.

I might be misremembering this and confusing it with a different issue, however, so I'm exploring this...

[Brady Eidson]

I used https://addons.mozilla.org/en-US/firefox/ to test this.

There's a search field there.  Enter text in the search field and search.  Then go back.

In Safari 2 the text is remembered.  In ToT, it is not.

*sigh*

[David Kilzer (:ddkilzer)]

<rdar://problem/5401041>

Fixed by Adele in <http://trac.webkit.org/projects/webkit/changeset/25064>.

Test in <http://trac.webkit.org/projects/webkit/changeset/25072>