Bug 14727 - [gdk] Move classes from WebCore/platform/gdk to WebKit/gtk/WebCoreSupport and adjust the namespace
Summary: [gdk] Move classes from WebCore/platform/gdk to WebKit/gtk/WebCoreSupport and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 14725
  Show dependency tree / graph
 
Reported: 2007-07-23 11:40 PDT by Holger Freyther
Modified: 2007-09-20 07:31 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2007-07-23 11:40:54 PDT 
At least move FrameLoaderClientGdk, FrameGdk from the WebCore namespace into the WebKitGtk namespace and move these files from WebCore/platform/gdk to WebKit/gtk/WebCoreSupport.

make sure to update WebCore/WebCore.pro as well and list the files we want to move in the comments.
Comment 1 Adam Roben (:aroben) 2007-07-23 11:42:28 PDT 
FrameGdk should not be moved, as it is a subclass of WebCore::Frame. I'd suggest FrameGdk be removed entirely (just as FrameMac/FrameWin/FrameQt were removed a few months ago).
Comment 2 Holger Freyther 2007-07-23 13:14:36 PDT 
Add the Gtk keyword, even to the curl bugs.
Comment 3 Holger Freyther 2007-08-09 19:00:31 PDT 
The first renaming is done, the next one is coming up:

WebKitGtk::FooClientGtk -> WebKit::FooClient
Comment 4 Holger Freyther 2007-09-20 07:31:15 PDT 
I think all relevant classes are in WebKit/gtk/WebCoreSupport and I don't plan to do any change to the names of these classes.