WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
14727
[gdk] Move classes from WebCore/platform/gdk to WebKit/gtk/WebCoreSupport and adjust the namespace
https://bugs.webkit.org/show_bug.cgi?id=14727
Summary
[gdk] Move classes from WebCore/platform/gdk to WebKit/gtk/WebCoreSupport and...
Holger Freyther
Reported
2007-07-23 11:40:54 PDT
At least move FrameLoaderClientGdk, FrameGdk from the WebCore namespace into the WebKitGtk namespace and move these files from WebCore/platform/gdk to WebKit/gtk/WebCoreSupport. make sure to update WebCore/WebCore.pro as well and list the files we want to move in the comments.
Attachments
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2007-07-23 11:42:28 PDT
FrameGdk should not be moved, as it is a subclass of WebCore::Frame. I'd suggest FrameGdk be removed entirely (just as FrameMac/FrameWin/FrameQt were removed a few months ago).
Holger Freyther
Comment 2
2007-07-23 13:14:36 PDT
Add the Gtk keyword, even to the curl bugs.
Holger Freyther
Comment 3
2007-08-09 19:00:31 PDT
The first renaming is done, the next one is coming up: WebKitGtk::FooClientGtk -> WebKit::FooClient
Holger Freyther
Comment 4
2007-09-20 07:31:15 PDT
I think all relevant classes are in WebKit/gtk/WebCoreSupport and I don't plan to do any change to the names of these classes.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug