Bug 14642 - REGRESSION(r24064-24096): Reflection type effect in canvas tag broke
Summary: REGRESSION(r24064-24096): Reflection type effect in canvas tag broke
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P1 Normal
Assignee: Nobody
URL: http://adam.yanalunas.com/projects/re...
Keywords: HasReduction, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2007-07-17 08:02 PDT by Dean Krueger
Modified: 2007-07-20 11:21 PDT (History)
1 user (show)

See Also:


Attachments
Reduction (644 bytes, text/html)
2007-07-17 19:35 PDT, Matt Lilek
no flags Details
First attempt (18.74 KB, patch)
2007-07-20 00:06 PDT, Rob Buis
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Krueger 2007-07-17 08:02:13 PDT
The fade off on the reflection is not working, if I use the normal Safari this page looks fine, I use the nightly build and the fade of the reflection is gone.
Comment 1 David Kilzer (:ddkilzer) 2007-07-17 08:50:59 PDT
Confirmed with a local debug build of WebKit r24303 with Safari 3.0 (522.12) on Mac OS X 10.4.10 (8R218).

Comment 2 David Kilzer (:ddkilzer) 2007-07-17 08:51:22 PDT
<rdar://problem/5340241>
Comment 3 Matt Lilek 2007-07-17 19:35:52 PDT
Created attachment 15558 [details]
Reduction
Comment 4 Matt Lilek 2007-07-17 19:40:36 PDT
Regressed between r24064 and r24096 with these two looking like the obvious commits:

http://trac.webkit.org/projects/webkit/changeset/24090
http://trac.webkit.org/projects/webkit/changeset/24091
Comment 5 Rob Buis 2007-07-20 00:06:46 PDT
Created attachment 15590 [details]
First attempt

I think the regression was caused by my attempt to fix the CGContextGetPathBoundingBox warnings. This fixes it in a different way, while still passing all tests.
Cheers,

Rob.
Comment 6 Darin Adler 2007-07-20 08:51:39 PDT
Comment on attachment 15590 [details]
First attempt

r=me -- my bad!
Comment 7 Rob Buis 2007-07-20 11:21:43 PDT
Landed in r24480.