RESOLVED FIXED 14632
Debug configuration doesn't work with qmake. 
https://bugs.webkit.org/show_bug.cgi?id=14632
Summary Debug configuration doesn't work with qmake.
Donald Luo
Reported 2007-07-16 06:43:51 PDT
Debug configuration is not really activated in the qmake build system. Set configuration to Debug and build WebKit for GDK or Qt. The executable built still doesn't contain debug information.
Attachments
Patch to webkitdirs.pm (884 bytes, patch)
2007-07-16 06:49 PDT, Donald Luo 		no flags
DetailsFormatted DiffDiff
enhanced patch (1.29 KB, patch)
2007-08-18 07:03 PDT, Oleg Sukhodolsky 		no flags
DetailsFormatted DiffDiff
the enhanced patch with corrected indentation (1.35 KB, patch)
2007-08-18 07:19 PDT, Oleg Sukhodolsky 		mrowe: review+
DetailsFormatted DiffDiff
change log for the patch (486 bytes, text/plain)
2007-08-18 13:12 PDT, Oleg Sukhodolsky 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Donald Luo
Comment 1 2007-07-16 06:49:00 PDT
Created attachment 15531 [details] Patch to webkitdirs.pm
Oleg Sukhodolsky
Comment 2 2007-08-18 07:03:18 PDT
Created attachment 16013 [details] enhanced patch as far as I know qmake could be configured to use debug configuration by default, so it looks reasonable to enhance the patch to explicitly drop unneedded mode.
Oleg Sukhodolsky
Comment 3 2007-08-18 07:19:39 PDT
Created attachment 16014 [details] the enhanced patch with corrected indentation
Holger Freyther
Comment 4 2007-08-18 07:21:17 PDT
I'm no perl expert but it looks okay.
Mark Rowe (bdash)
Comment 5 2007-08-18 07:25:46 PDT
Comment on attachment 16014 [details] the enhanced patch with corrected indentation r=me. The amount of duplication between buildQMakeProject and buildQMakeGdkProject is depressing. It'd be great if it could be cleaned up at some point.
Oleg Sukhodolsky
Comment 6 2007-08-18 07:35:11 PDT
(In reply to comment #5) > (From update of attachment 16014 [details] [edit]) > r=me. The amount of duplication between buildQMakeProject and > buildQMakeGdkProject is depressing. It'd be great if it could be cleaned up at > some point. > I will see what I can do to reduce duplication :)
Oleg Sukhodolsky
Comment 7 2007-08-18 13:12:19 PDT
Created attachment 16017 [details] change log for the patch
Holger Freyther
Comment 8 2007-08-19 04:20:20 PDT
Landed in r25146.
Note You need to log in before you can comment on or make changes to this bug.