Bug 14609 – gdk painting changes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Holger Freyther]

Various gdk painting changes spanning across multiple files including fixes for PlatformScrollbar, not using a GdkPixmap for drawing the themes because GraphicsContext will store the used native GdkWindow to draw on.

[Holger Freyther]

Created attachment 15502 [details]
Painting Chnages

Fix drawing of PlatformScrollbar, fix ownership of it, do not tripple buffer RenderThemeGdk, this should fix drawing rounded buttons as well. Lazily get the gdkDrawable as it might not be created at the time Widget::setGtkWidget is getting called. The drawable will exist when doing painting.

[Nikolas Zimmermann]

Comment on attachment 15502 [details]
Painting Chnages

 Hi Holger,

even though I'm not a gdk/gtk expert this looks like a nice patch.

I'm not sure wheter you are adhering to the style guide in the gdk port, if yes, tiny remark:

+struct FrameGdkExposeData{
+    GtkContainer *container;
+    GdkEventExpose *expose;
+};

missing space after {, stars should be moved.

+
+static void
+frame_gdk_expose_child(GtkWidget *widget, gpointer _data)
+{

Don't use two lines here.
Other than style remarks, all fine, r=me.

Greetings,
Niko

[Nikolas Zimmermann]

Comment on attachment 15502 [details]
Painting Chnages

 Hi Holger,

even though I'm not a gdk/gtk expert this looks like a nice patch.

I'm not sure wheter you are adhering to the style guide in the gdk port, if yes, tiny remark:

+struct FrameGdkExposeData{
+    GtkContainer *container;
+    GdkEventExpose *expose;
+};

missing space after {, stars should be moved.

+
+static void
+frame_gdk_expose_child(GtkWidget *widget, gpointer _data)
+{

Don't use two lines here.
Other than style remarks, all fine, r=me.

Greetings,
Niko

[Holger Freyther]

We do adhere the CodingStyle (well besides webkitgtklayout.c as in another patch). So please let me fix that before landing this patch.

[Holger Freyther]

Landed in r24322.