Bug 14603 – WebKitQt/WebCoreSupport is in INCLUDES for gdk-port

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Oleg Sukhodolsky]

For some reasons WebKitQt/WebCoreSupport is added to INCLUDES unconditionally.
It looks like it shouldn't be.  At least is not needed for gdk-port and, I suspect, that Windows and Mac also do not need it.
Here is a possible fix for this:

--- WebCore/WebCore.pro (revision 24253)
+++ WebCore/WebCore.pro (working copy)
@@ -114,8 +114,8 @@
                 $$PWD/html \
                 $$PWD/bindings/js \
                 $$PWD/ksvg2 $$PWD/ksvg2/css $$PWD/ksvg2/svg $$PWD/ksvg2/misc $$PWD/ksvg2/events \
-                $$PWD/platform/image-decoders \
-                $$PWD/../WebKitQt/WebCoreSupport
+                $$PWD/platform/image-decoders
+
 QT += network

[Oleg Sukhodolsky]

Created attachment 16015 [details]
gtk port does not need WebKitQt/WebCoreSupport

[Holger Freyther]

Agreed.

[Maciej Stachowiak]

Comment on attachment 16015 [details]
gtk port does not need WebKitQt/WebCoreSupport

Change looks good. Please write a ChangeLog entry. r- for lack of ChangeLog entry, will r+ once that is added.

[Oleg Sukhodolsky]

Created attachment 16033 [details]
the patch with the record for ChangeLog

here is the patch with update for ChangeLog (sorry I forgot to add it first time :(

[Holger Freyther]

Thank you for the patch. It was landed in r25350.