Bug 14576 – Patch to fix render theme for text fields in RenderThemeQt

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Andrea Cavalli]

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog   (revision 24155)
+++ WebCore/ChangeLog   (working copy)
@@ -1,3 +1,12 @@
[phone]  Andrea Cavalli  <[e-mail]>
+
+        Reviewed by NOBODY (OOPS!).
+
+       Fixed render theme for text field.
+       
+        * platform/qt/RenderThemeQt.cpp:
+        (WebCore::RenderThemeQt::paintTextField):
+
 2007-07-10  Adam Treat  <[e-mail]>
 
         Reviewed by George Staikos.
Index: WebCore/platform/qt/RenderThemeQt.cpp
===================================================================
--- WebCore/platform/qt/RenderThemeQt.cpp       (revision 24155)
+++ WebCore/platform/qt/RenderThemeQt.cpp       (working copy)
@@ -258,8 +258,12 @@ bool RenderThemeQt::paintTextField(Rende
         return true;
 
     QStyleOptionFrameV2 panel;
+    
     panel.initFrom(widget);
     panel.rect = r;
+    panel.state |= QStyle::State_Sunken;
+    panel.features = QStyleOptionFrameV2::None;
+
     // Get the correct theme data for a button
     EAppearance appearance = applyTheme(panel, o);
     Q_ASSERT(appearance == TextFieldAppearance);
@@ -267,7 +271,7 @@ bool RenderThemeQt::paintTextField(Rende
     // Now paint the text field.
     style->drawPrimitive(QStyle::PE_PanelLineEdit, &panel, painter, widget);
     style->drawPrimitive(QStyle::PE_FrameLineEdit, &panel, painter, widget);
-
+      
     return false;
 }

[Andrea Cavalli]

Created attachment 15464 [details]
Patch to fix rendering of text fields in WebKitQt

[George Staikos]

Thanks for the patch!  It's in.