Bug 14576 - Patch to fix render theme for text fields in RenderThemeQt
Summary: Patch to fix render theme for text fields in RenderThemeQt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 419.x
Hardware: Mac (Intel) OS X 10.4
: P2 Normal
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-10 12:28 PDT by Andrea Cavalli
Modified: 2007-07-10 15:33 PDT (History)
0 users

See Also:


Attachments
Patch to fix rendering of text fields in WebKitQt (1.39 KB, patch)
2007-07-10 12:43 PDT, Andrea Cavalli
staikos: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Cavalli 2007-07-10 12:28:24 PDT
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog   (revision 24155)
+++ WebCore/ChangeLog   (working copy)
@@ -1,3 +1,12 @@
+2007-07-10  Andrea Cavalli  <amc82@cam.ac.uk>
+
+        Reviewed by NOBODY (OOPS!).
+
+       Fixed render theme for text field.
+       
+        * platform/qt/RenderThemeQt.cpp:
+        (WebCore::RenderThemeQt::paintTextField):
+
 2007-07-10  Adam Treat  <adam@staikos.net>
 
         Reviewed by George Staikos.
Index: WebCore/platform/qt/RenderThemeQt.cpp
===================================================================
--- WebCore/platform/qt/RenderThemeQt.cpp       (revision 24155)
+++ WebCore/platform/qt/RenderThemeQt.cpp       (working copy)
@@ -258,8 +258,12 @@ bool RenderThemeQt::paintTextField(Rende
         return true;
 
     QStyleOptionFrameV2 panel;
+    
     panel.initFrom(widget);
     panel.rect = r;
+    panel.state |= QStyle::State_Sunken;
+    panel.features = QStyleOptionFrameV2::None;
+
     // Get the correct theme data for a button
     EAppearance appearance = applyTheme(panel, o);
     Q_ASSERT(appearance == TextFieldAppearance);
@@ -267,7 +271,7 @@ bool RenderThemeQt::paintTextField(Rende
     // Now paint the text field.
     style->drawPrimitive(QStyle::PE_PanelLineEdit, &panel, painter, widget);
     style->drawPrimitive(QStyle::PE_FrameLineEdit, &panel, painter, widget);
-
+      
     return false;
 }
Comment 1 Andrea Cavalli 2007-07-10 12:43:01 PDT
Created attachment 15464 [details]
Patch to fix rendering of text fields in WebKitQt
Comment 2 George Staikos 2007-07-10 15:33:08 PDT
Thanks for the patch!  It's in.