Bug 14504 - REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly
Summary: REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Major
Assignee: Nobody
URL: http://www.amazon.com/gp/sitbv3/reade...
Keywords: HasReduction, Regression
Depends on:
Blocks:
 
Reported: 2007-07-02 20:22 PDT by Jiang Jiang
Modified: 2007-07-07 09:53 PDT (History)
2 users (show)

See Also:


Attachments
a screenshot of that problem (70.47 KB, image/png)
2007-07-02 20:23 PDT, Jiang Jiang
no flags Details
a screenshot of correct rendering (in Safari 3.0.2) (187.77 KB, image/png)
2007-07-02 20:25 PDT, Jiang Jiang
no flags Details
Reduction (119 bytes, text/html)
2007-07-03 06:29 PDT, mitz
no flags Details
patch (42.73 KB, patch)
2007-07-04 00:34 PDT, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiang Jiang 2007-07-02 20:22:04 PDT
Amazon Book Excerpt can not be viewed in recent nightly, and a JavaScript except is thrown.
Comment 1 Jiang Jiang 2007-07-02 20:23:24 PDT
Created attachment 15358 [details]
a screenshot of that problem
Comment 2 Jiang Jiang 2007-07-02 20:25:55 PDT
Created attachment 15359 [details]
a screenshot of correct rendering (in Safari 3.0.2)
Comment 3 mitz 2007-07-03 06:29:33 PDT
Created attachment 15366 [details]
Reduction

<http://trac.webkit.org/projects/webkit/changeset/23573> (patch for bug 14211) made it impossible to shadow the 'toolbar' property with a variable.
Comment 4 Sam Weinig 2007-07-04 00:34:57 PDT
Created attachment 15380 [details]
patch

This patch moves the logic that allows the locals shadow window properties from KJS::Window to JSDOMWindow.
Comment 5 mitz 2007-07-04 01:03:18 PDT
Comment on attachment 15380 [details]
patch

r=me. How about using JavaScript to generate the big <script> element in the test?
Comment 6 Sam Weinig 2007-07-04 13:06:39 PDT
Landed in r23987.