Bug 14473 - Settings::m_usesPageCache might be uninitialized
Summary: Settings::m_usesPageCache might be uninitialized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-30 06:22 PDT by Holger Freyther
Modified: 2007-07-01 07:18 PDT (History)
0 users

See Also:


Attachments
Initialize Settings::m_usesPageCache (1.25 KB, patch)
2007-06-30 06:23 PDT, Holger Freyther
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2007-06-30 06:22:56 PDT
At least for the Gdk where Settings::setUsesPageCache is not called the above named variable might be uninitialized.
I have decided to make false the default value as the current non Mac ports (Qt,Gdk,Wx) do not have a PageCache implementation and the Mac port is calling Settings::setUsesPageCache through the WebView.mm wrapper
Comment 1 Holger Freyther 2007-06-30 06:23:56 PDT
Created attachment 15322 [details]
Initialize Settings::m_usesPageCache
Comment 2 Darin Adler 2007-06-30 08:03:59 PDT
Comment on attachment 15322 [details]
Initialize Settings::m_usesPageCache

r=me
Comment 3 Mark Rowe (bdash) 2007-07-01 07:18:56 PDT
Landed in r23910.