Bug 14448 – HTMLObjectElement::data should return an absolute URL

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: DOM

[Darin Fisher (:fishd, Google)]

HTMLObjectElement::data should return an absolute URL

The spec says to return an abs URL, Firefox returns an abs URL, but WebKit and IE both return a relative URL when this property is accessed.

Based on discussions on #webkit, it sounds like webkit should be changed to return an abs URL.

[Darin Fisher (:fishd, Google)]

patch w/ testcase coming up...

[Darin Fisher (:fishd, Google)]

Created attachment 15302 [details]
simple patch + testcase

This patch is modelled after the code for HTMLImageElement::src().  I changed the FrameLoader::completeURL call to a Document::completeURL as a minor simplification since HTMLObjectElement already has direct access to its Document.

[Darin Adler]

Comment on attachment 15302 [details]
simple patch + testcase

Looks good. r=me

What about the usemap attribute?

[Darin Fisher (:fishd, Google)]

Yes, good question.  I'll investigate and file a new bug if there are similar changed needed for that.

[Darin Fisher (:fishd, Google)]

It looks like FF and IE do not return an absolute URL for the DOM useMap property; however, Opera does.

[Mark Rowe (bdash)]

Landed in r23911.

[Mark Rowe (bdash)]

This introduced two test failures: <http://build.webkit.org/results/post-commit-powerpc-mac-os-x/7125/results.html>.  I will be rolling it out in a moment as we can't have regressions in the tree.

[Mark Rowe (bdash)]

Rolled out in r23913.  Please be sure to run the entire layout test suite when resubmitting an updated patch.

[Darin Fisher (:fishd, Google)]

It looks like fast/loader/xmlhttprequest-bad-mimetype is still failing even after this patch was rolled back.

That just leaves the two instances of object06.html (one for html and one for xhtml).  It turns out that both of those tests are actually asserting the opposite of this bug report.  They are testing that indeed the HTMLObjectElement's data accessor returns a relative URL instead of an absolute URL!  The object06.html test seems to originate from some w3.org test suite.  So, does that make this bug invalid??

[Mark Rowe (bdash)]

Comment on attachment 15302 [details]
simple patch + testcase

Changing to r- to get this out of the commit queue.

[Darin Fisher (:fishd, Google)]

*** This bug has been marked as a duplicate of 16799 ***