RESOLVED FIXED 14402
Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari" 
https://bugs.webkit.org/show_bug.cgi?id=14402
Summary Main resource of http://www.apple.com/safari/ is called "www.apple.com" inste...
Adam Roben (:aroben)
Reported 2007-06-25 19:49:54 PDT
If you inspect http://www.apple.com/safari/ you will notice that the main resource is labeled "www.apple.com", while it should be labeled "safari". Patch forthcoming.
Attachments
Patch with ChangeLog (2.06 KB, patch)
2007-06-25 19:52 PDT, Adam Roben (:aroben) 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2007-06-25 19:52:14 PDT
Created attachment 15234 [details] Patch with ChangeLog
Oliver Hunt
Comment 2 2007-06-25 20:09:30 PDT
Comment on attachment 15234 [details] Patch with ChangeLog this scares me as it could have substantial effects throughout webkit, are you sure there isn't anything that depends on this behaviour?
Adam Roben (:aroben)
Comment 3 2007-06-25 20:16:16 PDT
(In reply to comment #2) > (From update of attachment 15234 [details] [edit]) > this scares me as it could have substantial effects throughout webkit, are you > sure there isn't anything that depends on this behaviour? Surprisingly, there are only three calls to KURL::lastPathComponent outside of InspectorController.cpp. They are: 1) ClipboardWin.cpp::filesystemPathFromUrlOrTitle 2) ClipboardWin.cpp::writeURL 3) PasteboardWin.cpp::Pasteboard::writeURL I don't think any of these callers intended to get a "/" returned for http://www.apple.com/safari/, so I feel fairly safe making this change.
Oliver Hunt
Comment 4 2007-06-25 20:17:25 PDT
Comment on attachment 15234 [details] Patch with ChangeLog indeed you are correct, r=me
Adam Roben (:aroben)
Comment 5 2007-06-25 21:01:15 PDT
Landed as r23779
Note You need to log in before you can comment on or make changes to this bug.