Bug 14402 - Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
Summary: Main resource of http://www.apple.com/safari/ is called "www.apple.com" inste...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Adam Roben (:aroben)
URL: http://www.apple.com/safari/
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-25 19:49 PDT by Adam Roben (:aroben)
Modified: 2007-06-25 21:01 PDT (History)
0 users

See Also:


Attachments
Patch with ChangeLog (2.06 KB, patch)
2007-06-25 19:52 PDT, Adam Roben (:aroben)
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2007-06-25 19:49:54 PDT
If you inspect http://www.apple.com/safari/ you will notice that the main resource is labeled "www.apple.com", while it should be labeled "safari".

Patch forthcoming.
Comment 1 Adam Roben (:aroben) 2007-06-25 19:52:14 PDT
Created attachment 15234 [details]
Patch with ChangeLog
Comment 2 Oliver Hunt 2007-06-25 20:09:30 PDT
Comment on attachment 15234 [details]
Patch with ChangeLog

this scares me as it could have substantial effects throughout webkit, are you sure there isn't anything that depends on this behaviour?
Comment 3 Adam Roben (:aroben) 2007-06-25 20:16:16 PDT
(In reply to comment #2)
> (From update of attachment 15234 [details] [edit])
> this scares me as it could have substantial effects throughout webkit, are you
> sure there isn't anything that depends on this behaviour?

Surprisingly, there are only three calls to KURL::lastPathComponent outside of InspectorController.cpp. They are:

1) ClipboardWin.cpp::filesystemPathFromUrlOrTitle
2) ClipboardWin.cpp::writeURL
3) PasteboardWin.cpp::Pasteboard::writeURL

I don't think any of these callers intended to get a "/" returned for http://www.apple.com/safari/, so I feel fairly safe making this change.
Comment 4 Oliver Hunt 2007-06-25 20:17:25 PDT
Comment on attachment 15234 [details]
Patch with ChangeLog

indeed you are correct, r=me
Comment 5 Adam Roben (:aroben) 2007-06-25 21:01:15 PDT
Landed as r23779