Bug 14299 - fast/dom/HTMLDocument/frameless-location-bugzilla10837.html test is timing dependent
Summary: fast/dom/HTMLDocument/frameless-location-bugzilla10837.html test is timing de...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 523.x (Safari 3)
Hardware: All Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-21 16:18 PDT by Matt Perry
Modified: 2007-06-25 03:27 PDT (History)
0 users

See Also:

Attachments
patch (10.15 KB, patch)
2007-06-21 16:19 PDT, Matt Perry 		no flags Details | Formatted Diff | Diff
revised patch (10.19 KB, patch)
2007-06-21 17:11 PDT, Matt Perry 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Perry 2007-06-21 16:18:17 PDT 
I was able to get this test to fail on the Windows port because the second frame begins loading the data URL before the first frame was done.  On the Mac it appears that the second frame doesn't get to load in time, and the render tree is dumped prematurely.

I'm going to add a waitUntilDone() call to this test, so it always waits for the second frame to finish loading.
Comment 1 Matt Perry 2007-06-21 16:19:14 PDT 
Created attachment 15169 [details]
patch
Comment 2 mitz 2007-06-21 16:46:21 PDT 
Comment on attachment 15169 [details]
patch

+            f.location = 'data:text/html,%3Cbody onload=%22layoutTestController.notifyDone();%22%3Efoo%3C/body%3E';

I think it would be nicer if you checked for layoutTestController there too.
Comment 3 Matt Perry 2007-06-21 17:11:08 PDT 
Created attachment 15171 [details]
revised patch

Same as first patch, but with mitz's suggestion.
Comment 4 Sam Weinig 2007-06-24 22:04:29 PDT 
Comment on attachment 15171 [details]
revised patch

Looks good.
Comment 5 Mark Rowe (bdash) 2007-06-25 03:27:39 PDT 
Landed in r23760.