Bug 14287 - Don't add a null icon to the icon cache for every page without a favicon
Summary: Don't add a null icon to the icon cache for every page without a favicon
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-21 11:44 PDT by Adam Treat
Modified: 2007-06-21 13:20 PDT (History)
1 user (show)

See Also:


Attachments
Fix for this bug (1.39 KB, patch)
2007-06-21 11:45 PDT, Adam Treat
ggaren: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Treat 2007-06-21 11:44:12 PDT
Currently, the iconloader adds an icon to the cache whenever it hits an error page and it also adds a null icon to the cache for every page that doesn't have a favicon.  This makes sure to add an icon to the cache only when actual data exists.
Comment 1 Adam Treat 2007-06-21 11:45:03 PDT
Created attachment 15165 [details]
Fix for this bug
Comment 2 Oliver Hunt 2007-06-21 11:55:18 PDT
Comment on attachment 15165 [details]
Fix for this bug

Ok, this looks good, but i strongly suspect this will cause a perf regression.  

I suspect we cache null favicons to prevent us repeatedly trying to fetch a favicon from servers that don't have one.
Comment 3 Geoffrey Garen 2007-06-21 12:00:18 PDT
Comment on attachment 15165 [details]
Fix for this bug

We track these icons to avoid redundant network requests, which hurt performance.
Comment 4 Brady Eidson 2007-06-21 13:20:55 PDT
This behavior is intentional.  We track pages that don't have icons to prevent pinging the page for its icon every time.  There's expiration-date behavior here so we would re-request the icon once a day or once a week (I forget which), and we also re-request the icon if the user manually reloads the page.

Closing as invalid...