Bug 14260 – ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page

• Status: RESOLVED
• Resolution: FIXED
• Component: History

[David Kilzer (:ddkilzer)]

* SUMMARY
Going back in history on an image document or a plain text document causes an assertion failure in debug builds of ToT WebKit.

* STEPS TO REPRODUCE
1. Open Safari/WebKit.
2. Go to Bug 14256: http://bugs.webkit.org/show_bug.cgi?id=14256
3. Click on a "stack trace" attachment.
4. Click the browser Back button.

* ALTERNATE STEPS TO REPRODUCE
1. Open Safari/WebKit.
2. Go to URL:  http://webkit.org/blog/108/yet-another-one-more-thing-a-new-web-inspector/
3. Click on Inspector image.
4. Click the browser Back button.

* EXPECTED RESULTS
Safari should to back to the previous page.

* ACTUAL RESULTS
Assertion failure on debug builds of ToT WebKit.

* REGRESSION
This is a regression since the new Web Inspector landed on ToT WebKit.

* NOTES
Reproduced with Safari 3.0 (522.11) with a local debug build of WebKit r23678 on Mac OS X 10.4.10 (8R215 PRERELEASE).

Console output:

ASSERTION FAILED: m_mainResource->loader == loader
(/path/to/WebKit/WebCore/page/InspectorController.cpp:1059 void WebCore::InspectorController::didCommitLoad(WebCore::DocumentLoader*))
Segmentation fault

Stack trace:

Version:        3.0 (522.11)
Build Version:  2
Project Name:   WebBrowser
Source Version: 45221100

PID:    24226
Thread: 0

Exception:  EXC_BAD_ACCESS (0x0001)
Codes:      KERN_INVALID_ADDRESS (0x0001) at 0xbbadbeef

Thread 0 Crashed:
0   com.apple.WebCore        	0x014f7300 WebCore::InspectorController::didCommitLoad(WebCore::DocumentLoader*) + 260 (InspectorController.cpp:1059)
1   com.apple.WebCore        	0x014711b0 WebCore::FrameLoader::dispatchDidCommitLoad() + 148 (FrameLoader.cpp:4426)
2   com.apple.WebCore        	0x01481cc8 WebCore::FrameLoader::transitionToCommitted(WTF::PassRefPtr<WebCore::CachedPage>) + 1516 (FrameLoader.cpp:2476)
3   com.apple.WebCore        	0x01482358 WebCore::FrameLoader::commitProvisionalLoad(WTF::PassRefPtr<WebCore::CachedPage>) + 224 (FrameLoader.cpp:2360)
4   com.apple.WebCore        	0x01486e40 WebCore::DocumentLoader::loadFromCachedPage(WTF::PassRefPtr<WebCore::CachedPage>) + 144 (DocumentLoader.cpp:556)
5   com.apple.WebCore        	0x01472548 WebCore::FrameLoader::loadProvisionalItemFromCachedPage() + 228 (FrameLoader.cpp:3573)
6   com.apple.WebCore        	0x01477c40 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) + 864 (FrameLoader.cpp:3438)
7   com.apple.WebCore        	0x01477d98 WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) + 84 (FrameLoader.cpp:3392)
8   com.apple.WebCore        	0x01476e80 WebCore::FrameLoader::checkNavigationPolicy(WebCore::ResourceRequest const&, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, void (*)(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool), void*) + 364 (FrameLoader.cpp:3335)
9   com.apple.WebCore        	0x01478ddc WebCore::FrameLoader::load(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::FormState>) + 472 (FrameLoader.cpp:1990)
10  com.apple.WebCore        	0x0147f86c WebCore::FrameLoader::loadItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 976 (FrameLoader.cpp:3827)
11  com.apple.WebCore        	0x01480164 WebCore::FrameLoader::recursiveGoToItem(WebCore::HistoryItem*, WebCore::HistoryItem*, WebCore::FrameLoadType) + 1256 (FrameLoader.cpp:3989)
12  com.apple.WebCore        	0x01480290 WebCore::FrameLoader::goToItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 256 (FrameLoader.cpp:3932)
13  com.apple.WebCore        	0x011f1058 WebCore::Page::goToItem(WebCore::HistoryItem*, WebCore::FrameLoadType) + 404 (Page.cpp:139)
14  com.apple.WebCore        	0x011f114c WebCore::Page::goBack() + 88 (Page.cpp:115)
15  com.apple.WebKit         	0x003865f0 -[WebView goBack] + 80 (WebView.mm:2118)
16  com.apple.WebKit         	0x003890bc -[WebView(WebIBActions) goBack:] + 68 (WebView.mm:2611)
17  com.apple.AppKit         	0x9383ec4c -[NSApplication sendAction:to:from:] + 108
18  com.apple.Safari         	0x0001a020 0x1000 + 102432
19  com.apple.AppKit         	0x9383eb80 -[NSControl sendAction:to:] + 96
20  com.apple.AppKit         	0x9383ea60 -[NSCell _sendActionFrom:] + 156
21  com.apple.AppKit         	0x93858a88 -[NSCell trackMouse:inRect:ofView:untilMouseUp:] + 1020
22  com.apple.AppKit         	0x93858670 -[NSButtonCell trackMouse:inRect:ofView:untilMouseUp:] + 564
23  com.apple.AppKit         	0x93858094 -[NSControl mouseDown:] + 536
24  com.apple.Safari         	0x0007e474 0x1000 + 513140
25  com.apple.AppKit         	0x937f9890 -[NSWindow sendEvent:] + 4616
26  com.apple.Safari         	0x000ab334 0x1000 + 697140
27  com.apple.AppKit         	0x937a28d4 -[NSApplication sendEvent:] + 4172
28  com.apple.Safari         	0x00016444 0x1000 + 87108
29  com.apple.AppKit         	0x93799d10 -[NSApplication run] + 508
30  com.apple.AppKit         	0x9388a87c NSApplicationMain + 452
31  com.apple.Safari         	0x0000244c 0x1000 + 5196
32  com.apple.Safari         	0x0004f1b0 0x1000 + 319920

[David Kilzer (:ddkilzer)]

This occurs with HTML pages as well.

[Maxime BRITTO]

As far as I'm concerned, I can no longer use the back button without this assertion error.

*** Bug 14283 has been marked as a duplicate of this bug. ***

Sam removed the ASSERT in <http://trac.webkit.org/projects/webkit/changeset/23727>. Do you want to keep the bug open?

*** Bug 14301 has been marked as a duplicate of this bug. ***

[Maxime BRITTO]

Everything works now so do we need to keep it opened ?
At worst we'll be able to reopen it later if this assert was needed.

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> Sam removed the ASSERT in
> <http://trac.webkit.org/projects/webkit/changeset/23727>. Do you want to keep
> the bug open?

Closing since this issue has been resolved in r23727.

[David Kilzer (:ddkilzer)]

Added bug info to ChangeLog entry.

$ svn commit WebCore/ChangeLog
Sending        WebCore/ChangeLog
Transmitting file data .
Committed revision 23752.