WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
14193
Move the Screen object out of the JS bindings
https://bugs.webkit.org/show_bug.cgi?id=14193
Summary
Move the Screen object out of the JS bindings
Sam Weinig
Reported
2007-06-16 19:48:16 PDT
Forthcoming patch moves the Screen object out of the JS bindings code and autogenerates a wrapper instead.
Attachments
patch
(77.17 KB, patch)
2007-06-16 20:12 PDT
,
Sam Weinig
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2007-06-16 20:12:36 PDT
Created
attachment 15081
[details]
patch
Sam Weinig
Comment 2
2007-06-16 20:16:24 PDT
One change from the old code that this patch makes is that the properties of the Screen object used to be DontEnum|ReadOnly and now are DontDelete|ReadOnly. I found no documentation or reason that the screen properties should be non-enumeratable and deletable so I changed them to be just like all the the other js objects we generate. This change is visible in the changed results of the regression tests.
Geoffrey Garen
Comment 3
2007-06-18 11:23:42 PDT
Comment on
attachment 15081
[details]
patch r=me Will the other platforms' projects need to change to accommodate the new file paths? Maybe you should send email to webkit-dev.
Sam Weinig
Comment 4
2007-06-18 17:21:21 PDT
Landed in
r23576
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug