Bug 14153 - Need RenderSVGViewportContainer sublcass for RenderSVGContainer
Summary: Need RenderSVGViewportContainer sublcass for RenderSVGContainer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-14 17:27 PDT by Eric Seidel (no email)
Modified: 2007-08-10 07:41 PDT (History)
0 users

See Also:


Attachments
Initial patch (27.39 KB, patch)
2007-08-10 07:31 PDT, Nikolas Zimmermann
rwlbuis: review+
Details | Formatted Diff | Diff
LayoutTests results (236.71 KB, text/plain)
2007-08-10 07:31 PDT, Nikolas Zimmermann
rwlbuis: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-06-14 17:27:21 PDT
Need RenderSVGViewportContainer sublcass for RenderSVGContainer

RenderSVGContainer should be only for viewport-less containers (such as <g>) and RenderSVGViewportContainer should be for <pattern> and <symbol>, etc.
Comment 1 Nikolas Zimmermann 2007-08-10 07:31:08 PDT
Created attachment 15907 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2007-08-10 07:31:57 PDT
Created attachment 15908 [details]
LayoutTests results
Comment 3 Rob Buis 2007-08-10 07:38:12 PDT
Comment on attachment 15907 [details]
Initial patch

Some whitespace changes may be unneeded, but otherwise fine.
Comment 4 Rob Buis 2007-08-10 07:38:39 PDT
Comment on attachment 15908 [details]
LayoutTests results

All fine, r=me.
Comment 5 Nikolas Zimmermann 2007-08-10 07:41:31 PDT
Landed in r(In reply to comment #0)
> Need RenderSVGViewportContainer sublcass for RenderSVGContainer
> 
> RenderSVGContainer should be only for viewport-less containers (such as <g>)
> and RenderSVGViewportContainer should be for <pattern> and <symbol>, etc.

Just one comment here:
<pattern> don't have associated RenderObjects at all. Same for symbols.
Currently it really only applies to makers and inner <svg> elements.

Greetings,
Niko
Comment 6 Nikolas Zimmermann 2007-08-10 07:41:54 PDT
Landed in r24991.