Bug 14089 - Can't build Qt version
Summary: Can't build Qt version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Linux
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-12 09:14 PDT by Mike Hommey
Modified: 2015-01-23 22:51 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Hommey 2007-06-12 09:14:05 PDT 
Changeset 22027[1], introducing plugins loading, breaks the build because the added qwebobjectplugin_p.h[2] file includes a private header: private/qfactoryloader_p.h that is not included. I'm not sure including private headers is a good idea anyways... so it would be better, IMHO, to do whatever is possible to *not* include qwebobjectplugin_p.h at all.

1. http://trac.webkit.org/projects/webkit/changeset/22027
2. http://trac.webkit.org/projects/webkit/browser/trunk/WebKitQt/Api/qwebobjectplugin_p.h?rev=22027
Comment 1 George Staikos 2007-06-13 10:30:57 PDT 
Has been fixed.