Bug 14068 - [S60] : stream requests are cancelled after "javascript:" execution
Summary: [S60] : stream requests are cancelled after "javascript:" execution
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 523.x (Safari 3)
Hardware: S60 Hardware S60 3rd edition
: P1 Critical
Assignee: Nobody
URL: http://www.v28power.com/flash.htm
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-11 06:35 PDT by Mahesh Kulkarni
Modified: 2008-04-09 11:39 PDT (History)
1 user (show)

See Also:


Attachments
return after executing javascript. (597 bytes, patch)
2007-06-11 06:44 PDT, Mahesh Kulkarni
Sachin.Padma: review-
Details | Formatted Diff | Diff
attached changeLog (1.12 KB, patch)
2007-06-14 06:56 PDT, Mahesh Kulkarni
Sachin.Padma: review-
Details | Formatted Diff | Diff
Attached change log with latest code (1.08 KB, patch)
2007-06-18 05:37 PDT, Mahesh Kulkarni
Sachin.Padma: review+
Details | Formatted Diff | Diff
3.1 patch (1.10 KB, patch)
2007-07-09 23:51 PDT, Mahesh Kulkarni
Sachin.Padma: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mahesh Kulkarni 2007-06-11 06:35:51 PDT
Problem with requests from plugin to getUrl with "javascript" in it. After executing "javascript:" in getUrl calls of plugins, pending requests are getting canceled. This is also observed when plugin makes a request for invalid page. (i.e error page, like 404). Pending requests should not be canceled and browser should continue downloading pending requests from plugin.  

- Steps to reproduce:
1. www.v28power.com/flash.htm in browser. 
2. Activate the flash content
3. Select any one of the tools. 
More Info:
Please refer TSW ERR_ID: DSOA-73HB9R 

- Actual outcome:
The tool picture enlarges and no tooltip texts are displayed. 

- Expected outcome:
The tool picture should enlarge and tooltip text should be displayed.
Comment 1 Mahesh Kulkarni 2007-06-11 06:44:41 PDT
Created attachment 14933 [details]
return after executing javascript.

_REASON:
After Javascript execution is happened, browser continues making a get requests to resourceLoader. Invalid requests makes browser to cancel pending requests of plugin.

_SOLUTION:
Return from function CPluginLoader::LoadPluginContentL after execution of javascript. Even if javascript has a URL to load script engine will take care of loading the given URL. Making get request to network doesn't required when "javascript:" is present in URL.

_MODULES_EFFECTED:
WebKit\Plugin plugin loader

_TSW ERR_ID: DSOA-73HB9R
Comment 2 Sachin Padma 2007-06-13 06:55:33 PDT
Comment on attachment 14933 [details]
return after executing javascript.

Please attach changelog
Comment 3 Mahesh Kulkarni 2007-06-14 06:56:56 PDT
Created attachment 15019 [details]
attached changeLog
Comment 4 Mahesh Kulkarni 2007-06-14 06:57:51 PDT
Comment on attachment 15019 [details]
attached changeLog

Attached changeLog along with the fix.
Comment 5 Sachin Padma 2007-06-15 10:41:09 PDT
Comment on attachment 15019 [details]
attached changeLog

Attach changelog to the beginning. Patch does not apply. Please update your SVN workearea and recreate the patch
Comment 6 Mahesh Kulkarni 2007-06-18 05:37:55 PDT
Created attachment 15098 [details]
Attached change log with latest code

Attached change log with latest code
Comment 7 Sachin Padma 2007-06-21 08:04:07 PDT
Comment on attachment 15098 [details]
Attached change log with latest code

r=me
Comment 8 Sachin Padma 2007-06-21 08:04:42 PDT
landed in ccb in r23716
Comment 9 Mahesh Kulkarni 2007-07-09 23:51:25 PDT
Created attachment 15460 [details]
3.1 patch 

Branch approved.
Comment 10 Sachin Padma 2007-07-16 08:26:32 PDT
Comment on attachment 15460 [details]
3.1 patch 

r=me
Comment 11 Sachin Padma 2007-07-16 08:29:44 PDT
landed in 3.1m in r24315
Comment 12 Bradley Morrison 2008-04-09 11:39:25 PDT
Bulk closing of all s60 platform bugs. 

Sorry for the noise!