WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
14008
RenderTextControl.cpp hard-codes scrollbar size to 15 pixels
https://bugs.webkit.org/show_bug.cgi?id=14008
Summary
RenderTextControl.cpp hard-codes scrollbar size to 15 pixels
Darin Fisher (:fishd, Google)
Reported
2007-06-05 19:47:55 PDT
RenderTextControl.cpp hard-codes scrollbar size to 15 pixels the comments say that this should use RenderTheme instead. after discussing with maciej on #webkit, it seems like the best solution is a method on RenderTheme that takes a RenderObject parameter so that the scrollbar size can vary (e.g., on OS X, mini controls have a smaller scrollbar).
Attachments
simple patch
(2.43 KB, patch)
2007-06-05 20:42 PDT
,
Darin Fisher (:fishd, Google)
hyatt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1
2007-06-05 20:42:23 PDT
Created
attachment 14874
[details]
simple patch I went with the simpler version of the patch since other code in rendering/ invokes PlatformScrollbar::horizontalScrollbarHeight()/verticalScrollbarWidth() Moreover, this ends up not being a real code change since it's just replacing a hard-coded 15 with a static function that returns 15 (on Mac).
Dave Hyatt
Comment 2
2007-06-05 20:59:41 PDT
Comment on
attachment 14874
[details]
simple patch r=me
Mark Rowe (bdash)
Comment 3
2007-06-05 21:28:26 PDT
Landed in
r22017
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug