Bug 14008 - RenderTextControl.cpp hard-codes scrollbar size to 15 pixels
Summary: RenderTextControl.cpp hard-codes scrollbar size to 15 pixels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P3 Minor
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-05 19:47 PDT by Darin Fisher (:fishd, Google)
Modified: 2007-06-05 21:28 PDT (History)
0 users

See Also:


Attachments
simple patch (2.43 KB, patch)
2007-06-05 20:42 PDT, Darin Fisher (:fishd, Google)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2007-06-05 19:47:55 PDT
RenderTextControl.cpp hard-codes scrollbar size to 15 pixels

the comments say that this should use RenderTheme instead.  after discussing with maciej on #webkit, it seems like the best solution is a method on RenderTheme that takes a RenderObject parameter so that the scrollbar size can vary (e.g., on OS X, mini controls have a smaller scrollbar).
Comment 1 Darin Fisher (:fishd, Google) 2007-06-05 20:42:23 PDT
Created attachment 14874 [details]
simple patch

I went with the simpler version of the patch since other code in rendering/ invokes PlatformScrollbar::horizontalScrollbarHeight()/verticalScrollbarWidth()

Moreover, this ends up not being a real code change since it's just replacing a hard-coded 15 with a static function that returns 15 (on Mac).
Comment 2 Dave Hyatt 2007-06-05 20:59:41 PDT
Comment on attachment 14874 [details]
simple patch

r=me
Comment 3 Mark Rowe (bdash) 2007-06-05 21:28:26 PDT
Landed in r22017.