Bug 13972 – Quicktime does not respect CSS clip and overflow

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Plug-ins

[Dave Hyatt]

Flash and Netscape plugins respect it now, but Quicktime (a Webkit plugin) does not.  It relies on NSView's visibleRect method to know what to clip.  This bug tracks reworking all plugins so that visibleRect is the way to clip.

[Dave Hyatt]

Created attachment 14835 [details]
Patch that fixes Quicktime.

[Dave Hyatt]

Fixed.

[Dave Hyatt]

Backed out this fix since it regressed mail.

[Mark Rowe (bdash)]

Created attachment 15093 [details]
Override the WebKit plugin view's visibleRect method to respect clip and overflow

This patch fixes QuickTime clipping without breaking Mail.  It does this in a somewhat hackish way:  it swizzles the plugin view's visibleRect implementation with one that understands WebCore clipping.  This approach would be much less likely to interfere with applications such as Mail that use custom WebKit plugins to provide functionality.  The tradeoff is that the approach feels a bit nasty.

It's worth noting that the MethodSwizzle.* files are under an MIT-style license.  I'm not clear whether that's acceptable for inclusion in WebKit.  It also lacks support for the new Obj-C runtime, I can implementat that before this is reviewed if the general approach is deemed nasty-but-acceptable.

[Mark Rowe (bdash)]

Comment on attachment 14835 [details]
Patch that fixes Quicktime.

Clearing review as most of this patch was rolled out.

[David Harrison]

rdar://problem/4338918

[Simon Fraser (smfr)]

No longer an issue with composited plugins.