Bug 13914 - REGRESSION: Kotoeri mode switching behavior incorrect
Summary: REGRESSION: Kotoeri mode switching behavior incorrect
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2007-05-29 17:17 PDT by Daniel Acosta
Modified: 2007-07-08 18:03 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Acosta 2007-05-29 17:17:24 PDT
When switching between Kotoeri modes using the keyboard, previous selected text changes its script.

To reproduce:
1. Focus any standard input box in any site and switch to Kotoeri Katakana mode
2. Input any text that can be written with katakana like Kotoeri (result: コトエリ)
3. Without pressing anything or changing focus switch to Romaji mode using the keyboard shortcut Ctrl+Shit+;
4. The text you typed shoud change to it's romaji equivalent (f.e. kotoeri)

I think this is related to http://bugs.webkit.org/show_bug.cgi?id=13605, but that problem was resolved some other way, so it's a better idea posting this as a separate lower priority bug... the behavior doesnt occur in standard Safari.
Comment 1 Alexey Proskuryakov 2007-05-29 21:37:26 PDT
Confirmed as a regression with r21802 (the problem is in step 4 - the text _shouldn't_ change to Romaji, but it does).
Comment 2 Alexey Proskuryakov 2007-06-05 12:01:20 PDT
The bad things happen inside WebHTMLView's _interceptEditingKeyEvent:

#0	0x00362884 in -[WebHTMLView(WebNSTextInputSupport) setMarkedText:selectedRange:] at WebHTMLView.mm:5380
<...>
#31	0x9387f8a0 in -[NSView interpretKeyEvents:]
#32	0x003680e0 in -[WebHTMLView(WebInternal) _interceptEditingKeyEvent:shouldSaveCommand:] at WebHTMLView.mm:5189

I'm not sure whether this means that -[NSView interpretKeyEvents:] is being called at a wrong time, or just that WebKit doesn't properly implement some other feature needed by Kotoeri.
Comment 3 Alexey Proskuryakov 2007-06-22 04:11:25 PDT
rdar://5287270
Comment 4 Oliver Hunt 2007-06-27 02:32:05 PDT
This is not reproducable afaict.  Quite probably fixed by r23813
Comment 5 Alexey Proskuryakov 2007-06-27 11:39:00 PDT
Works for me now, too.