Bug 13914 – REGRESSION: Kotoeri mode switching behavior incorrect

• Status: CLOSED
• Resolution: FIXED
• Component: Text

[Daniel Acosta]

When switching between Kotoeri modes using the keyboard, previous selected text changes its script.

To reproduce:
1. Focus any standard input box in any site and switch to Kotoeri Katakana mode
2. Input any text that can be written with katakana like Kotoeri (result: コトエリ)
3. Without pressing anything or changing focus switch to Romaji mode using the keyboard shortcut Ctrl+Shit+;
4. The text you typed shoud change to it's romaji equivalent (f.e. kotoeri)

I think this is related to http://bugs.webkit.org/show_bug.cgi?id=13605, but that problem was resolved some other way, so it's a better idea posting this as a separate lower priority bug... the behavior doesnt occur in standard Safari.

[Alexey Proskuryakov]

Confirmed as a regression with r21802 (the problem is in step 4 - the text _shouldn't_ change to Romaji, but it does).

[Alexey Proskuryakov]

The bad things happen inside WebHTMLView's _interceptEditingKeyEvent:

#0	0x00362884 in -[WebHTMLView(WebNSTextInputSupport) setMarkedText:selectedRange:] at WebHTMLView.mm:5380
<...>
#31	0x9387f8a0 in -[NSView interpretKeyEvents:]
#32	0x003680e0 in -[WebHTMLView(WebInternal) _interceptEditingKeyEvent:shouldSaveCommand:] at WebHTMLView.mm:5189

I'm not sure whether this means that -[NSView interpretKeyEvents:] is being called at a wrong time, or just that WebKit doesn't properly implement some other feature needed by Kotoeri.

[Alexey Proskuryakov]

rdar://5287270

[Oliver Hunt]

This is not reproducable afaict.  Quite probably fixed by r23813

[Alexey Proskuryakov]

Works for me now, too.