Bug 13905 - REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
Summary: REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest res...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2007-05-29 10:21 PDT by Alexey Proskuryakov
Modified: 2007-06-21 12:04 PDT (History)
2 users (show)

See Also:


Attachments
test case (1.72 KB, application/zip)
2007-05-29 10:35 PDT, Alexey Proskuryakov
no flags Details
proposed fix (6.88 KB, patch)
2007-06-21 10:55 PDT, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2007-05-29 10:21:38 PDT
rdar://5185933

This widget gets an HTML response, and the response encoding is determined by a Http-Equiv META. Shipping WebKit is naive enough to just feed any XHR responses to an HTML/XML decoder, so it always honors METAs. However, TOT matches other browsers (and the current draft spec) in that it only looks inside XML responses for encoding information.

The good news is that it has been suggested that browsers should also look inside HTML responses in order to implement XHR.responseHTML some day (or to extend responseXML to work with HTML). So, maybe we can still get the spec changed.
Comment 1 Alexey Proskuryakov 2007-05-29 10:35:47 PDT
Created attachment 14768 [details]
test case
Comment 2 Anders Carlsson 2007-05-29 10:46:12 PDT
If we can't get the spec changed, we need to add yet another dashboard quirk :/
Comment 3 Anne van Kesteren 2007-06-20 09:19:21 PDT
The specification is actually already changed :-)

http://www.w3.org/TR/XMLHttpRequest/#text-response-entity-body
Comment 4 Alexey Proskuryakov 2007-06-21 10:55:53 PDT
Created attachment 15163 [details]
proposed fix
Comment 5 Anders Carlsson 2007-06-21 11:31:28 PDT
Comment on attachment 15163 [details]
proposed fix

Great work! r=me
Comment 6 Alexey Proskuryakov 2007-06-21 12:04:36 PDT
Committed revision 23718.