RESOLVED FIXED 13889
[gdk] Concentrate on browsing and disable editing by changing EditorClientGdk 
https://bugs.webkit.org/show_bug.cgi?id=13889
Summary [gdk] Concentrate on browsing and disable editing by changing EditorClientGdk
Holger Freyther
Reported 2007-05-26 18:54:44 PDT
I would like to concentrate on browsing, implementing proper selection etc. first and then eventually get back to editing.
Attachments
Disable editing of HTML (1.01 KB, patch)
2007-05-26 18:55 PDT, Holger Freyther 		mjs: review+
DetailsFormatted DiffDiff
Disable whole-view editing for the Gdk port (1.71 KB, patch)
2007-06-05 08:57 PDT, Holger Freyther 		mrowe: review+
DetailsFormatted DiffDiff
Disable whole-view editing for the Gdk port (1.08 KB, patch)
2007-06-06 12:59 PDT, Holger Freyther 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2007-05-26 18:55:52 PDT
Created attachment 14744 [details] Disable editing of HTML Disable editing to allow me to concentrate on the browsing stuff.
Maciej Stachowiak
Comment 2 2007-05-28 23:30:10 PDT
I think this patch is probably the a good idea, but the reasoning behind it is not quite right. This method is meant to be an override to force whole-view editability. So returning false doesn't prevent all editing, areas marked contentEditable would still allow editing. But it was almost certainly wrong for this method to return "true" in the first place, since it would force all content to always be editable.
Maciej Stachowiak
Comment 3 2007-05-28 23:31:31 PDT
Comment on attachment 14744 [details] Disable editing of HTML r=me but you may want to fix the ChangeLog entry to more accurately reflect what this patch actually does.
Holger Freyther
Comment 4 2007-05-29 01:49:29 PDT
I will update the ChangeLog and thank your for your comments.
Holger Freyther
Comment 5 2007-06-05 08:57:32 PDT
Created attachment 14869 [details] Disable whole-view editing for the Gdk port Slightly improve the ChangeLog. I sincerly hope it is enough.
Sam Weinig
Comment 6 2007-06-06 11:50:26 PDT
Can you please re-create this patch using svn-create-patch so it can be applied cleanly.
Holger Freyther
Comment 7 2007-06-06 12:59:59 PDT
Created attachment 14888 [details] Disable whole-view editing for the Gdk port Created with svn-createPatch now. Would something like git-applyPatch be accepted upstream?
Mark Rowe (bdash)
Comment 8 2007-06-06 23:27:14 PDT
Holger, I think a script to create patches from git that are compatible with svn-apply-patch would be preferred.
Mark Rowe (bdash)
Comment 9 2007-06-10 16:09:41 PDT
Landed in r22088.
Darin Adler
Comment 10 2007-06-21 23:48:27 PDT
Comment on attachment 14888 [details] Disable whole-view editing for the Gdk port r=me I think you could even take out the notImplemented() call -- no special reason you have to offer a whole-view editable mode, thus no reason to keep track of this as a "not implemented" function.
Note You need to log in before you can comment on or make changes to this bug.