Bug 13855 - Port patch 666176 to JavaScriptCore
Summary: Port patch 666176 to JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Other OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-24 03:54 PDT by Luciano Montanaro
Modified: 2007-05-24 16:53 PDT (History)
0 users

See Also:


Attachments
Change occurrences of downcast to asCell (7.11 KB, patch)
2007-05-24 03:55 PDT, Luciano Montanaro
no flags Details | Formatted Diff | Diff
New version of the patch, with changelog. (8.47 KB, patch)
2007-05-24 07:38 PDT, Luciano Montanaro
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luciano Montanaro 2007-05-24 03:54:32 PDT
rename JSObject::downcast() to asCell(), which should make the meaning cleaner
Comment 1 Luciano Montanaro 2007-05-24 03:55:53 PDT
Created attachment 14701 [details]
Change occurrences of downcast to asCell
Comment 2 David Kilzer (:ddkilzer) 2007-05-24 05:19:13 PDT
Comment on attachment 14701 [details]
Change occurrences of downcast to asCell

Thanks for the patch!

Again, please set the "review?" flag, and please review the code contribution guidelines here:  http://webkit.org/coding/contributing.html
Comment 3 Luciano Montanaro 2007-05-24 07:38:54 PDT
Created attachment 14704 [details]
New version of the patch, with changelog.
Comment 4 Darin Adler 2007-05-24 09:42:58 PDT
Comment on attachment 14701 [details]
Change occurrences of downcast to asCell

Seems fine, r=me
Comment 5 David Kilzer (:ddkilzer) 2007-05-24 09:52:26 PDT
Comment on attachment 14701 [details]
Change occurrences of downcast to asCell

Clearing old review flag.
Comment 6 Sam Weinig 2007-05-24 16:53:22 PDT
Landed in r21736.