Bug 13854 - Port of commit 667785 from kjs
Summary: Port of commit 667785 from kjs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Other OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-24 02:27 PDT by Luciano Montanaro
Modified: 2007-05-26 15:21 PDT (History)
1 user (show)

See Also:


Attachments
The two-line patch (378 bytes, patch)
2007-05-24 02:29 PDT, Luciano Montanaro
darin: review-
Details | Formatted Diff | Diff
Result of the localeCompare testcases with IE6 (3.09 KB, text/plain)
2007-05-25 01:02 PDT, Luciano Montanaro
no flags Details
patch with updated test case (3.87 KB, patch)
2007-05-25 11:37 PDT, Sam Weinig
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luciano Montanaro 2007-05-24 02:27:49 PDT
The log for that change says:
"fixed special no-args case I discovered when writing tests
more or less accidentally".
Comment 1 Luciano Montanaro 2007-05-24 02:29:43 PDT
Created attachment 14700 [details]
The two-line patch

The patch for the backported fix
Comment 2 David Kilzer (:ddkilzer) 2007-05-24 05:16:14 PDT
Comment on attachment 14700 [details]
The two-line patch

Please set the "review?" flag on patches you'd like reviewed.  Thanks!

This patch also needs a ChangeLog and a layout test.  See: http://webkit.org/coding/contributing.html
Comment 3 Darin Adler 2007-05-24 09:42:03 PDT
Comment on attachment 14700 [details]
The two-line patch

Needs a test.
Comment 4 Darin Adler 2007-05-24 09:47:21 PDT
Comment on attachment 14700 [details]
The two-line patch

Patch is great.

We need both a change log and a layout test for this, as Dave says.
Comment 5 Luciano Montanaro 2007-05-25 01:02:00 PDT
Created attachment 14712 [details]
Result of the localeCompare testcases with IE6

testcase log showing IE6 has a different behavior vs. Firefox.
Comment 6 Harri Porten 2007-05-25 09:23:16 PDT
Given the IE6 test results that Luciano kindly attached to this report I suddenly developed some doubts about this patch. I only discovered this special case by accident when writing a test. But if Firefox is the only browser showing this behavior I am tempted to remove it again from Konqueror. Might base this decision on what you guys do, though.
Comment 7 Sam Weinig 2007-05-25 11:37:32 PDT
Created attachment 14728 [details]
patch with updated test case

This patch includes the changes and updates fast/js/kde/StringObject.html to match kde which include new localeCompare tests.  It should be noted that both IE and Opera do not match this behavior, but Firefox does.
Comment 8 Sam Weinig 2007-05-25 11:38:45 PDT
My concerns mirror Harri's.
Comment 9 Darin Adler 2007-05-26 08:45:57 PDT
Comment on attachment 14728 [details]
patch with updated test case

r=me
Comment 10 Sam Weinig 2007-05-26 15:21:46 PDT
Landed in r21806.