RESOLVED FIXED 13791
Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement 
https://bugs.webkit.org/show_bug.cgi?id=13791
Summary Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement
Sam Weinig
Reported 2007-05-20 18:19:18 PDT
Patch forthcoming.
Attachments
patch (39.70 KB, patch)
2007-05-20 18:22 PDT, Sam Weinig 		sam: review-
DetailsFormatted DiffDiff
updated patch (35.99 KB, patch)
2007-05-21 09:52 PDT, Sam Weinig 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2007-05-20 18:22:40 PDT
Created attachment 14638 [details] patch
Adam Roben (:aroben)
Comment 2 2007-05-20 18:34:13 PDT
Comment on attachment 14638 [details] patch Is it possible to merge JSHTMLFrameElementCustom.cpp and JSHTMLIFrameElementCustom.cpp into one file that uses HTMLFrameOwnerElement? It seems a shame to have this duplicated code.
Sam Weinig
Comment 3 2007-05-21 09:52:11 PDT
Created attachment 14643 [details] updated patch Instead of using [Custom] to implement the security check I have added a [CheckSecurity] attribute and updated the bindings scripts to handle it. This should resolves the code duplication issue and makes the patch a little cleaner.
Adam Roben (:aroben)
Comment 4 2007-05-21 10:31:41 PDT
Comment on attachment 14643 [details] updated patch + // alias for DOM JS DOM bindings I don't think you need two of them are needed. r=me
Sam Weinig
Comment 5 2007-05-21 15:52:47 PDT
Landed in r21624.
Note You need to log in before you can comment on or make changes to this bug.