Bug 13762 - Non qt/mac ports are broken after 21517
Summary: Non qt/mac ports are broken after 21517
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-17 12:14 PDT by Holger Freyther
Modified: 2007-05-18 05:46 PDT (History)
1 user (show)

See Also:


Attachments
Fix the build (394 bytes, patch)
2007-05-17 12:15 PDT, Holger Freyther
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2007-05-17 12:14:00 PDT
The commit broke all non qt/non mac ports. This is due m_data being undeclared for them. The following patch is going to fix it.
Comment 1 Holger Freyther 2007-05-17 12:15:21 PDT
Created attachment 14596 [details]
Fix the build
Comment 2 Maciej Stachowiak 2007-05-17 17:31:36 PDT
Comment on attachment 14596 [details]
Fix the build

r=me
Comment 3 Mark Rowe (bdash) 2007-05-18 01:57:04 PDT
Holger, can you please provide patches that work with svn-apply and contain ChangeLog entries in the future?  Thanks!

Landed in r21558.
Comment 4 David Kilzer (:ddkilzer) 2007-05-18 05:46:22 PDT
(In reply to comment #3)
> Holger, can you please provide patches that work with svn-apply and contain
> ChangeLog entries in the future?  Thanks!

More info here:  http://webkit.org/coding/contributing.html