Bug 13735 - REGRESSION: Image documents have white space below the image
Summary: REGRESSION: Image documents have white space below the image
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2007-05-15 13:40 PDT by mitz
Modified: 2007-05-24 02:26 PDT (History)
0 users

See Also:

Attachments
Make the image 'display: block' (29.66 KB, patch)
2007-05-15 13:46 PDT, mitz 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-05-15 13:40:59 PDT 
Image documents have white space below the image. Patch forthcoming.
Comment 1 mitz 2007-05-15 13:46:32 PDT 
Created attachment 14572 [details]
Make the image 'display: block'

Includes a test.
Comment 2 Darin Adler 2007-05-15 13:48:03 PDT 
Comment on attachment 14572 [details]
Make the image 'display: block'

r=me
Comment 3 mitz 2007-05-15 23:13:59 PDT 
Comment on attachment 14572 [details]
Make the image 'display: block'

Sam let me know that this patch affects several existing layout tests. I am going to make a new version.
Comment 4 mitz 2007-05-16 05:02:16 PDT 
Styling the image is bad because it breaks fast/events/standalone-image-drag-to-editable.html . Maybe there is a way to style <body> to get rid of the white space.
Comment 5 mitz 2007-05-23 22:57:14 PDT 
Fixed in <http://trac.webkit.org/projects/webkit/changeset/21686> by enabling quirks mode for image documents. One of the quirks is that inlines with no text children do not affect top/bottom calculation.
Comment 6 Dave Hyatt 2007-05-24 02:26:07 PDT 
Layout tests broke from this change, since the body will stretch to fill the viewport in quirks mode.