Bug 13722 – Finish testing and fixing the setting of DOM attributes to JS null

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Sam Weinig]

A number of attributes that were not tested in bug 13541 should be tested and if need be fixed.  These include:

-from the Core DOM
CharacterData.data
ProcessingInstruction.data
Attr.value

-from the CSSOM
CSSPageRule.selectorText
CSSRule.cssText
CSSStyleDeclaration.cssText
CSSStyleRule.selectorText
CSSValue.cssText
MediaList.mediaText

-from  the SVG DOM
SVGElement.id
SVGElement.xmlbase
SVGAngle.valueAsString
SVGLength.valueAsString
SVGScriptElement.type

-and from CanvasRenderingContext2D
CanvasRenderingContext2D.globalCompositeOperation
CanvasRenderingContext2D.lineCap
CanvasRenderingContext2D.lineJoin
CanvasRenderingContext2D.shadowColor

Test cases forthcoming

[Sam Weinig]

Created attachment 14570 [details]
patch to fix Core DOM attributes

This patch fixes the remaining attributes in the Core DOM (CharacterData.data, ProcessingInstruction.data, and Attr.value).  Patched Attr.value to not throw an exception for null values as this matches the spec and Firefox.

[Darin Adler]

Comment on attachment 14570 [details]
patch to fix Core DOM attributes

How about using dumpAsText for this test?

         [ConvertNullStringTo=Null, OldStyleObjC] DOMString substringData(in [IsIndex] unsigned long offset, 
-                                                           in [IsIndex] unsigned long length)
+                                                                         in [IsIndex] unsigned long length)

I'm not a big fan of "high-maintenance" formatting that requires changes to indentation when you rename things or add keywords. Maybe we can reconsider the way we're formatting .idl files at some point.

r=me

[Sam Weinig]

Landed first patch in r21489 with Darin's suggestions.  Keeping bug open for remaining cases.

[Sam Weinig]

Created attachment 14575 [details]
Patch to fix CSSOM attributes

Patch changes and tests the CSSOM attributes.  I could not test the PageRule one as we never create a PageRule as far as I can tell.

[Sam Weinig]

Created attachment 14576 [details]
Patch to fix CanvasRenderingContext2D attributes

[Sam Weinig]

Created attachment 14578 [details]
Patch to fix SVG attributes

Last one.

[Oliver Hunt]

Comment on attachment 14578 [details]
Patch to fix SVG attributes

yay for idl!

[Sam Weinig]

Second patch landed in r21502.  Third in r21504.

[Sam Weinig]

Last patch landed in r21505!

[Lucas Forschler]

Mass moving XML DOM bugs to the "DOM" Component.