Bug 13697 - rename pcre.h to pcre-{utf, local?}.h so as not to conflict with pcre.h in include path
Summary: rename pcre.h to pcre-{utf, local?}.h so as not to conflict with pcre.h in in...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-12 05:47 PDT by Alexander Botero-Lowry
Modified: 2022-07-25 17:34 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Botero-Lowry 2007-05-12 05:47:29 PDT
qmake puts pkgconfig include pathes before local ones, so during a qt build it will often happen that the path where pcre.h is on a normal system is included in the pkgconfig path (for me /usr/local/include) and so the unicode safe pcre.h that is in tree is ignored. This should/could be remedied by renaming the header in tree.
Comment 1 Mark Rowe (bdash) 2007-05-12 05:51:09 PDT
Files with the same name inside the source tree should win over "system" header files.  Renaming the file would likely resolve the problem, but the more correct fix would be to have the build system pass the correct include paths to the compiler.
Comment 2 Alexander Botero-Lowry 2007-05-12 06:16:30 PDT
zackr tells me this is probably a qmake issue which doesn't present in his system, so he can't really fix it. Though I agree the problem should be fixed in qmake I'm at a loss as to what that'd take.
Comment 3 Ahmad Saleem 2022-07-25 13:47:24 PDT
Only reference to PCRE, I can find within C++ code on Webkit Github repo was this line in comment:

https://github.com/WebKit/WebKit/blob/c9fb599a37ed367b3daece9eac1c461ef142b267/Source/JavaScriptCore/yarr/YarrParser.h#L1222

I think PCRE remnants have been removed and I think we can close this bug? Thanks!
Comment 4 Alexey Proskuryakov 2022-07-25 17:34:03 PDT
Yes, we have an entirely different regex implementation now.