Bug 13688 – REGRESSION (r20943+): Colloquy doesn't show any messages

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Adam Roben (:aroben)]

Sometime after r20943, Colloquy stopped showing messages.

Repro steps:
1. Launch Colloquy with DYLD_FRAMEWORK_PATH set to a post-r20943 WebKit
2. Type a message

Results:
The message doesn't appear in the chat window.

[Timothy Hatcher]

Created attachment 14502 [details]
Test case

This test should fill the whole view port green.

[Timothy Hatcher]

This has to do with CSS tables. Colloquy has a body CSS rule:

body { display: table }

And other rules for table-row and table-cell.

I'll look at redoing this in Colloquy (it was rather whacky, but it worked!)

[Timothy Hatcher]

This test works in Firefox also.

[Dave Hyatt]

Created attachment 14503 [details]
More complicated test case to really illustrate the problem

Firefox 2 and Safari 2 both fail this one too.  WebKit fails it the worst though.

[Dave Hyatt]

Created attachment 14504 [details]
Patch to fix bug

The behavior in this patch exactly matches Gran Paradiso Alpha 4.  Empty cells (with no lines) had their baseline wrongly at the top in FFX2 (one of the reasons it failed Acid2).  Now that the baseline of the cell is on the bottom, Gran Paradiso Alpha 4 passes this test case as well.  I even tried putting text in cell 2 in the test case, wondering if the cell would move such that it hung out of the table itself.  It did indeed do that with both my patch and Gran Paradiso.

[Dave Hyatt]

Fixed in r21425.