RESOLVED INVALID Bug 13669
Canvas transformations affect path construction 
https://bugs.webkit.org/show_bug.cgi?id=13669
Summary Canvas transformations affect path construction
Ian 'Hixie' Hickson
Reported 2007-05-10 16:30:47 PDT
STEPS TO REPRODUCE 1. Create a path. 2. Set a transformation. 3. Fill the path. ACTUAL RESULTS Transformation is ignored. EXPECTED RESULTS Transformation should have an affect. STEPS TO REPRODUCE 1. Set a transformation. 2. Create a path. 3. Undo the transformation. 4. Fill the path. ACTUAL RESULTS Transformation is applied. EXPECTED RESULTS Transformation should have no affect.
Attachments
Patch that fixes problem (1.01 KB, patch)
2007-05-11 14:49 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ian 'Hixie' Hickson
Comment 2 2007-05-11 14:20:21 PDT
As mentioned on IRC, it would be really great to have this fixed soon so that we can determine whether this is possible to fix or not. If it's not possible to fix then we should change the spec, but that would make the platform quite sucky so I'd like to avoid doing that if at all possible. (You'd have to redraw the path everytime you wanted to paint it somewhere new, instead of being able to create the path once and rapidly paint it in multiple places.)
Oliver Hunt
Comment 3 2007-05-11 14:49:29 PDT
Created attachment 14497 [details] Patch that fixes problem Okay, this fixes behaviour to match spec -- still need to confirm that this doesn't destroy dashboard
Eric Seidel (no email)
Comment 4 2007-10-01 09:49:35 PDT
Hum. This looks like a really easy fix. The only problem is that it sounds like there needs to be some check of dashboard widgets with this patch applied. That's probably best done by some apple person (with access to leopard)... and probably that will only happen post-leopard (possibly compounding the problem).
Ian 'Hixie' Hickson
Comment 5 2007-10-29 13:27:23 PDT
So this didn't make Safari 3... can we get a post-mortem? Was it too incompatible, requiring this to become WONTFIX? Or is it still something we can do?
Oliver Hunt
Comment 6 2008-01-27 19:25:17 PST
For canvas.isPointInPath to be implemented completely and according to spec we need to land this patch. Although i hate to suggest it, should we consider having a dashboard compatibility quirk for this? I don't think we ever confirmed whether or not this would break dashboard. It should be noted however that firefox has this same behaviour.
Oliver Hunt
Comment 7 2008-01-27 19:31:39 PST
Oooh, it occurs to me, could we make this dependent on being in html5 "strict"? eg. switch on the presence of the html5 doctype? (this type of compat quirk is new to me so i don't know how it works/if it's possible... i'm hoping hyatt would know :D ) Thoughts anyone?
Ian 'Hixie' Hickson
Comment 8 2008-01-28 17:45:12 PST
The spec changed recently, since Firefox and Safari refused to change to this behaviour, and the Opera guys requested that the spec change to match them. Thus I believe this bug is now invalid.
Oliver Hunt
Comment 9 2008-01-28 17:52:16 PST
IT's a shame as feel the old specced behaviour was better in a number of ways -- ithnk we should really consider adding a Path object to HTML5
Note You need to log in before you can comment on or make changes to this bug.