Bug 13650 - Gdk port needs ImageBuffer implementation (build fixlets)
Summary: Gdk port needs ImageBuffer implementation (build fixlets)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-09 13:21 PDT by Holger Freyther
Modified: 2007-05-10 21:02 PDT (History)
1 user (show)

See Also:

Attachments
gdk build fixlet (4.26 KB, patch)
2007-05-09 13:31 PDT, Holger Freyther 		mrowe: review+
Details | Formatted Diff | Diff
Implement ImagebufferCairo using ciaro_image_surface (3.26 KB, patch)
2007-05-10 07:36 PDT, Holger Freyther 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2007-05-09 13:21:02 PDT 
To make the Gdk port (compiled with qmake) link an Implementation of ImageBuffer is needed. This report adds a stub and fixes a newbie issue.
Comment 1 Holger Freyther 2007-05-09 13:31:32 PDT 
Created attachment 14438 [details]
gdk build fixlet

-Add ImageBuffer stubs for cairo
-Always include config.h. Sorry for the newbie error.
Comment 2 Mark Rowe (bdash) 2007-05-09 15:00:04 PDT 
Comment on attachment 14438 [details]
gdk build fixlet

There are a few minor formatting issues with this patch, but I'll fix those as I land it.
Comment 3 Mark Rowe (bdash) 2007-05-09 15:04:42 PDT 
Landed in r21340.
Comment 4 Holger Freyther 2007-05-10 07:36:25 PDT 
Created attachment 14465 [details]
Implement ImagebufferCairo using ciaro_image_surface

Now an untested ImageBufferCairo implementation. Sadly it is untested as there is no easy way to test the platform/graphics classes.
Comment 5 Holger Freyther 2007-05-10 07:37:07 PDT 
New patch => reopening
Comment 6 Mark Rowe (bdash) 2007-05-10 21:01:50 PDT 
Holger, we don't reuse bugs for new patches.  Can you please file a new bug specifically relating to your new patch and attach the patch to it?