Bug 13614 - [S60] 3.2 BrowserNG: Find Phonenumber doesn't make a call
Summary: [S60] 3.2 BrowserNG: Find Phonenumber doesn't make a call
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: Other S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-07 12:48 PDT by George Guo
Modified: 2008-06-11 00:22 PDT (History)
1 user (show)

See Also:


Attachments
solution patch (3.38 KB, patch)
2007-05-07 13:14 PDT, George Guo
Sachin.Padma: review-
Details | Formatted Diff | Diff
new patch with modifications based on previous review (4.55 KB, patch)
2007-05-09 11:02 PDT, George Guo
Sachin.Padma: review-
Details | Formatted Diff | Diff
New patch (5.59 KB, patch)
2007-05-10 15:09 PDT, George Guo
Sachin.Padma: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description George Guo 2007-05-07 12:48:23 PDT
Please specify the following information:
QC test case  - ]MSK - Auto find off - phone num

- Use case:
Preconditions:
Browser is running.
Options/Preferences/Page/Smart text recognition set to Off (§qtn_browsers_sett_smartlink§ in §qtn_browsers_title_page§ )
Load page http://testsuite.nokia-boston.com/content/S60NG_autofinditem/search_auto_manual.html
- Steps to reproduce:
1.Select Options/ Find/Phone number (§qtn_options_find§ -> §qtn_options_find_phone_number§)
2.Options menu is closed. 
3. Move the pointer to the first phone number on the page. Phone number in the page is identified with a call icon "phone" next to it. 
3. Press Selection Key
- Expected outcome:
A call to the number in focus will be initiated when selectection key was selected
- Actual outcome:
No call was made when selection key was selected. Nothing happends. The same page was displayed.

Lotus Notes ID: ISHG-6YFNME
Comment 1 George Guo 2007-05-07 13:14:00 PDT
Created attachment 14400 [details]
solution patch

This is the solution for bug ISHG-6YFME
Comment 2 Sachin Padma 2007-05-08 08:01:52 PDT
Comment on attachment 14400 [details]
solution patch

Formatting is not correct. Also LC function is used inside a non LC function.
Comment 3 George Guo 2007-05-09 11:02:12 PDT
Created attachment 14435 [details]
new patch with modifications based on previous review

New patch with modifications based on previous review were added
Comment 4 Sachin Padma 2007-05-10 12:53:48 PDT
Comment on attachment 14435 [details]
new patch with modifications based on previous review

does not need to be member variable
Comment 5 George Guo 2007-05-10 15:09:08 PDT
Created attachment 14477 [details]
New patch 

The member object was taken away, and Leave function were taken care of
Comment 6 Sachin Padma 2007-05-10 15:23:08 PDT
Comment on attachment 14477 [details]
New patch 

r=me
Comment 7 Sachin Padma 2007-05-10 15:24:35 PDT
landed in ccb in r21382