I spent some time trying to figure out the font fallback, caching, and glyph systems. It is complex and not well-documented. We should provide some better comments explaining what is going on.
Created attachment 14405 [details] Add comments for glyph files. This adds more comments to the glyph system. I also added one assertion.
I'll handle this.
Comment on attachment 14405 [details] Add comments for glyph files. The comments conflict with the changes in bug 3315 (which moves the roots among other things).
Comment on attachment 14405 [details] Add comments for glyph files. Clearing the review bit. I'm going to tweak these comments a bit in order to keep them consistent with 3315.
Thanks Dave!
Ok, landed. Thanks for taking the time to write these comments. They helped me spot a bug in my changes in 3315. :)
Going to have to make GlyphPages refcounted.