Bug 13587 - WebKitQt build fails if MacPorts has pcre installed.
Summary: WebKitQt build fails if MacPorts has pcre installed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-04 07:20 PDT by Erik L. Bunce
Modified: 2007-05-06 19:58 PDT (History)
1 user (show)

See Also:


Attachments
This removes the depenency on MacPorts (1.75 KB, patch)
2007-05-04 07:22 PDT, Erik L. Bunce
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik L. Bunce 2007-05-04 07:20:41 PDT
WebKitQt qmake files have a dependency on MacPorts that can break the build if the user has a MacPorts install of pcre.

/regexp.o ../../../JavaScriptCore/kjs/regexp.cpp
../../../JavaScriptCore/kjs/regexp.cpp: In constructor 'KJS::RegExp::RegExp(const KJS::UString&, int)':
../../../JavaScriptCore/kjs/regexp.cpp:51: error: cannot convert 'const uint16_t*' to 'const char*' for argument '1' to 'pcre* pcre_compile(const char*, int, const char**, int*, const unsigned char*)'
../../../JavaScriptCore/kjs/regexp.cpp:56: error: cannot convert 'const uint16_t*' to 'const char*' for argument '1' to 'pcre* pcre_compile(const char*, int, const char**, int*, const unsigned char*)'
../../../JavaScriptCore/kjs/regexp.cpp: In member function 'KJS::UString KJS::RegExp::match(const KJS::UString&, int, int*, int**)':
../../../JavaScriptCore/kjs/regexp.cpp:139: error: cannot convert 'const uint16_t*' to 'const char*' for argument '3' to 'int pcre_exec(const pcre*, const pcre_extra*, const char*, int, int, int, int*, int)'
make[1]: *** [tmp/regexp.o] Error 1
make: *** [sub-WebCore-make_default-ordered] Error 2
Comment 1 Erik L. Bunce 2007-05-04 07:22:25 PDT
Created attachment 14342 [details]
This removes the depenency on MacPorts

This patch removes the dependency on MacPorts and fixes the build.
Comment 2 Mark Rowe (bdash) 2007-05-05 09:59:39 PDT
Comment on attachment 14342 [details]
This removes the depenency on MacPorts

r=me
Comment 3 Mark Rowe (bdash) 2007-05-06 19:58:10 PDT
Landed in r21277.