Bug 13582 - Ctrl-S doesn't work as expected
Summary: Ctrl-S doesn't work as expected
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac (Intel) OS X 10.4
: P4 Normal
Assignee: Nobody
URL: http://www.clublexus.com/forums/showt...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-03 18:33 PDT by Vishal Agrawal
Modified: 2008-02-20 07:22 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vishal Agrawal 2007-05-03 18:33:02 PDT
vraa19:40:26  oh i have a webkit question
vraa19:40:51  when i press ctrl+s on a vbulletin forum after editing a post, it pretends to post a new post, and then it gives me (it being the forum) an error saying that i need to actually post content
vraa19:41:11  when infact, webkit should read the ctrl+s for the save button to save the edited post, rather than pretending there is a new post
bdash19:47:21  vraa: what does ctlr-s do?
bdash19:47:26  *ctrl-s
Hwin19:50:15  save
Hwin left the chat room. ()
vraa19:55:12  post
vraa19:55:15  execute action
vraa19:55:20  i dunno, i press ctrl+s to post a reply
vraa19:55:30  usually it's "post reply" or "save" or "submit thread"
bdash19:57:26  ok, so how is ctrl-s being treated as Save?
bdash19:57:35  via an access key? via JS?
CIA-519:57:46  bdash Safari-522 * r21241 / (4 files in 4 dirs): Versioning.
AngryLuke19:58:15  has anyone graphed the amount of open p1 bugs over time?
CIA-519:58:56  bdash Safari-4522.7 * r21242 /: New tag.
vraa19:59:26  bdash: i dont know how to explain it
vraa19:59:30  um, i guess perhaps javascript?
bdash20:00:20  vraa: does clicking the equivalent button on the page work correctly?
vraa20:00:25  yep!
vraa20:00:33  but i'm so used to using the keyboard, hence i told you guys about it
bdash20:00:41  ok, so you should file a bug report then
vraa20:00:49  is it a bug though? because i dont want to annoy you guys
Catfish_Man joined the chat room.
jibot20:01:12  Catfish_Man is an Adium developer
bdash20:01:33  vraa: what makes you think asking a question on IRC is less annoying than asking the same question in a bug report? :)
vraa20:01:44  because you can kick me from irc :D
Catfish_Man20:01:51  hello
vraa20:01:57  do i file it in the bugreporterapple.com thing?
bdash20:01:59  vraa: something "not working" is almost certainly a bug, the question is whether it is our bug or the websites bug
vraa20:02:00  hi Catfish_Man
Catfish_Man20:02:05  hi vraa
bdash20:02:09  no, you'd file it at webkit.org/new-bug
vraa20:02:17  oh, that's a good point bdash, let me see if i can replicate it on other vbulletin boards
vraa20:03:26  okay, i think this might be a vbulletin error... or an option which breaks webkit, let me try camino
vraa20:05:25  camino handles it correctly.
bdash20:05:46  vraa: even if it works in camino it doesn't necessarily tell you whether it's a WebKit or vbulletin error, many websites have code that doesn't different things in different browsers, and there's no guarantee the code being executed in Safari is even correct
vraa20:05:49  okay now i think camino is broken
vraa20:05:54  ajax sucks.
dkirker left the chat room. ("Bye bye!!")
vraa20:06:22  okay here's what i've concluded
vraa20:06:40  webkit handles regular quick reply posts. camino doesn't. camino handles edits using ajax, webkit doesnt.
vraa20:07:49  bdash: yeah, you're right, is there any way to narrow it down or to even trick webkit/safari into thinking that "hey, when i press ctrl+s and i'm editing a post using ajax, save it, dont think it's a new post" ?
vraa20:08:08  it's not that big of a hassle, since i can press back, press "edit post" and my edits are there (they aren't gone / erased)

----------------------------------------------------------------------------

Essentially what is going on is that I think webkit is not reading the keyboard input right and directing it to the right button.

When I make a post on Clublexus and use CTRL+S as the shortcut to submit the post, it works fine. It doesn't work in Camino though -- so +1 for Webkit :)
However on Clublexus (I can't do it on Ferrarichat or MBWorld because they use the full editor, not inline editing) when I edit a post and I press ctrl+s it'll think I'm trying to submit a new post and take me to the full editor for a new post saying that I have to have at least 10 characters to make a new post. However when I press BACK to go back to the previous page and I press EDIT POST, my edits are there. I have to use my mouse to press SAVE to apply the edits to the post. With Camino if I press ctrl+s while I'm in the inline editor, it'll save the changes to the post rather than thinking I want to make a brand new post.
Comment 1 Mark Rowe (bdash) 2007-05-03 18:47:28 PDT
This is likely either an access key or JS issue, potentially in WebKit-specific JS used in the forum software.  I've registered an account on the forums with WebKit/webkit  and am waiting for it to be activated so I can test.
Comment 2 Oliver Hunt 2007-06-27 20:06:11 PDT
This is clearly a p1, assigning to self
Comment 3 Oliver Hunt 2007-06-27 20:07:21 PDT
ignore last comment, bugzilla going weird on me
Comment 4 Robert Blaut 2008-02-20 03:32:20 PST
P5 is not used for WebKit bugs. [http://webkit.org/quality/bugpriorities.html]
Comment 5 Alexey Proskuryakov 2008-02-20 07:22:31 PST
I tried to test, but it looks like the account hasn't been activated.