Bug 13529 – DOM3 keyIdentifier text is incorrect

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Darin Fisher (:fishd, Google)]

DOM3 keyIdentifier text is incorrect

When pressing the 'A' key, Safari produces 'U+000041' instead of 'U+0041' as specified here:
http://www.w3.org/TR/DOM-Level-3-Events/keyset.html#KeySet-Set

Maciej suggested that this is either a bug or behavior that was based on an earlier version of the DOM3 events spec.  In any case, it seems like a bug, and since no other major browsers (IE, FF, Opera) seem to support the keyIdentifier property, it is probably something that can be fixed without breaking existing pages.

[Darin Fisher (:fishd, Google)]

Indeed, this version of the spec says 'U+000041':
http://www.w3.org/TR/2003/WD-DOM-Level-3-Events-20030331/keyset.html

[Maciej Stachowiak]

I suggest we update it to what the latest draft says.

[Rob Buis]

Created attachment 14518 [details]
First attempt

This causes no regressions on my mac build, I wasn't able to test others (Qt run-webkit-tests is broken here, I don't (yet) have access to the other builds).
Cheers,

Rob.

Comment on attachment 14518 [details]
First attempt

Based on the ChangeLog, the patch appears to be incomplete.

[Rob Buis]

Created attachment 14532 [details]
Now with complete source code

Mitz was right, this one should be complete. I blame it on multiple patches in the local tree :/
Cheers,

Rob.

Comment on attachment 14532 [details]
Now with complete source code

Still missing a few?

+        * platform/gdk/KeyEventGdk.cpp:
+        (WebCore::keyIdentifierForGdkKeyCode):

+        * platform/win/KeyEventWin.cpp:
+        (WebCore::keyIdentifierForWindowsKeyCode):
+        * platform/wx/KeyEventWin.cpp:
+        (WebCore::keyIdentifierForWindowsKeyCode):
e

[Darin Adler]

Comment on attachment 14532 [details]
Now with complete source code

I am worried about compatibility, but lets just get this change in and track the DOM 3 events standard.

r=me

[Rob Buis]

Landed in r21445.