Bug 13498 - Remove currently non working CMake buildsystem
Summary: Remove currently non working CMake buildsystem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-26 06:35 PDT by Holger Freyther
Modified: 2007-05-02 02:42 PDT (History)
0 users

See Also:

Attachments
Remove CMakeLists and invocations (71.45 KB, patch)
2007-04-26 06:36 PDT, Holger Freyther 		mjs: review+
Details | Formatted Diff | Diff
Remove the last trace of CMake (1.66 KB, patch)
2007-05-01 07:29 PDT, Holger Freyther 		mrowe: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2007-04-26 06:35:16 PDT 
The CMake buildsystem was introduced for the Qt/KDE port of WebKit. This port switched over to use qmake and the cmake buildsystem is currently not used by any other port.
I propose to remove it.
Comment 1 Holger Freyther 2007-04-26 06:36:21 PDT 
Created attachment 14199 [details]
Remove CMakeLists and invocations
Comment 2 Holger Freyther 2007-04-26 06:46:40 PDT 
Comment on attachment 14199 [details]
Remove CMakeLists and invocations

I forgot to set the review flag. It is now set.
Comment 3 Maciej Stachowiak 2007-04-26 22:38:22 PDT 
Comment on attachment 14199 [details]
Remove CMakeLists and invocations

Sounds ok to me.
Comment 4 Mark Rowe (bdash) 2007-04-27 00:58:17 PDT 
Landed in r21138.  Thanks Holger!
Comment 5 Holger Freyther 2007-05-01 07:29:15 PDT 
Created attachment 14294 [details]
Remove the last trace of CMake

I missed a (unreachable) call to CMake in build-webkit. This patch removes this call. The isQtWithQMake() method became irrelevant and was removed.
Comment 6 Holger Freyther 2007-05-01 07:30:31 PDT 
Sorry for the inconvience, I have missed one spot in the CMake removal and this patch makes it up.
Comment 7 Mark Rowe (bdash) 2007-05-02 02:42:40 PDT 
Landed in r21220.