REGRESSION: Some content missing from www.kyte.tv

[Charles Gaudette]

The content shows in Safari 2 .0.4 (419.3), but fails in WebKit r21060. The missing content is Flash, but the error seems to be the JavaScript. The page displays "Your Adobe Flash Plug-in is not up to date. Click here for more information.", but the Flash plugin works correctly on the site's own test page, http://www.kyte.tv/home/noflash.html .

Terminal reports:
[PID] http://www.kyte.tv/home/index.html line 276: TypeError: Undefined value

This seems to me to be similar to http://bugs.webkit.org/show_bug.cgi?id=11375 , but not exactly.

[Mark Rowe (bdash)]

if (typeof HTMLElement != "undefined") {

    if(HTMLElement.prototype.__defineGetter__) {

        HTMLElement.prototype.__defineGetter__("innerText", function()
        {
            var tmp = this.innerHTML.replace(/<br>/gi, "\n");       ### <--- This line is throwing the exception.
            return tmp.replace(/<[^>]+>/g, "").replace(/&nbsp;/g, " ");
        });

        HTMLElement.prototype.__defineSetter__("innerText", function(txtStr)
        {
            var parsedText = document.createTextNode(txtStr);
            this.innerHTML = "";
            this.appendChild(parsedText);
        });
    }

    if (HTMLElement.prototype.attachEvent==undefined) HTMLElement.prototype.attachEvent = window.attachEvent;
    if (HTMLElement.prototype.detachEvent==undefined) HTMLElement.prototype.detachEvent = window.detachEvent;

}

[David Kilzer (:ddkilzer)]

Regressions are P1.

[Mark Rowe (bdash)]

<rdar://problem/5166139>

[Maxime BRITTO]

It seems to come from a script error. The developper in charge of this script used an / before the < at line 276. But the '<' doesn't need the '/' to be found.
With this new line 276 :
var tmp = this.innerHTML.replace(<br\s*[/]?\s*>/gi, "\n");

The script keep up loading and flash pugin is detected.But it still don't work because I just copied the index.html and script.js on my hard drive to test.

[Maxime BRITTO]

(In reply to comment #4)
> The script keep up loading and flash pugin is detected.But it still doesn't work
> because I just copied the index.html and script.js on my hard drive to test.

When I say it doesn't work it's just a security measure with an alert message blocking a local file from openning a distant adress through the flash pugin.
Even after this alert, I can see the flash animation in the page, trying to connect.

[Maxime BRITTO]

I can't reproduce this bug on Safari 3.0 and webkit r23789.
They did change the line 276 which was the origyn of the problem.
There is now two new JS errors but I can't see any visible consequences.

I think it was an evangelism issue.

[Oliver Hunt]

I can't see any problem with the flash, and the preceeding comment implies the bug was in the site rather than webkit