Bug 13442 - Yahoo.com does not render properly in GDK port
Summary: Yahoo.com does not render properly in GDK port
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-21 19:08 PDT by Atul Mehrotra
Modified: 2007-07-02 17:44 PDT (History)
1 user (show)

See Also:

Attachments
yahoo.com dont show proper page because of User Agent string (53.82 KB, patch)
2007-04-21 19:16 PDT, Atul Mehrotra 		no flags Details | Formatted Diff | Diff
patch for adding correct User Agent String. (1.90 KB, patch)
2007-04-21 19:31 PDT, Atul Mehrotra 		mrowe: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Atul Mehrotra 2007-04-21 19:08:49 PDT 
Yahoo.com does not render correct page.
Comment 1 Atul Mehrotra 2007-04-21 19:16:55 PDT 
Created attachment 14131 [details]
yahoo.com dont show proper page because of User Agent string
Comment 2 Atul Mehrotra 2007-04-21 19:31:21 PDT 
Created attachment 14132 [details]
patch for adding correct User Agent String.
Comment 3 Mark Rowe (bdash) 2007-04-21 19:35:41 PDT 
Comment on attachment 14132 [details]
patch for adding correct User Agent String.

You have a setter method which ignores its argument and uses a constant string.  You then never use the member variable which is set, instead adding another constant string.  You are also missing a ChangeLog entry.
Comment 4 Mark Rowe (bdash) 2007-04-21 19:51:14 PDT 
Comment on attachment 14132 [details]
patch for adding correct User Agent String.

I'll also mention that the user agent string that you chose to use is clearly incorrect.  You are not using WebKit version 410, nor are you likely to be on a PowerPC machine running OS X.
Comment 5 Alp Toker 2007-07-02 17:44:49 PDT 
yahoo.com works properly using the gdk port/GdkLauncher TOT.