WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WORKSFORME
13442
Yahoo.com does not render properly in GDK port
https://bugs.webkit.org/show_bug.cgi?id=13442
Summary
Yahoo.com does not render properly in GDK port
Atul Mehrotra
Reported
2007-04-21 19:08:49 PDT
Yahoo.com does not render correct page.
Attachments
yahoo.com dont show proper page because of User Agent string
(53.82 KB, patch)
2007-04-21 19:16 PDT
,
Atul Mehrotra
no flags
Details
Formatted Diff
Diff
patch for adding correct User Agent String.
(1.90 KB, patch)
2007-04-21 19:31 PDT
,
Atul Mehrotra
mrowe
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Atul Mehrotra
Comment 1
2007-04-21 19:16:55 PDT
Created
attachment 14131
[details]
yahoo.com dont show proper page because of User Agent string
Atul Mehrotra
Comment 2
2007-04-21 19:31:21 PDT
Created
attachment 14132
[details]
patch for adding correct User Agent String.
Mark Rowe (bdash)
Comment 3
2007-04-21 19:35:41 PDT
Comment on
attachment 14132
[details]
patch for adding correct User Agent String. You have a setter method which ignores its argument and uses a constant string. You then never use the member variable which is set, instead adding another constant string. You are also missing a ChangeLog entry.
Mark Rowe (bdash)
Comment 4
2007-04-21 19:51:14 PDT
Comment on
attachment 14132
[details]
patch for adding correct User Agent String. I'll also mention that the user agent string that you chose to use is clearly incorrect. You are not using WebKit version 410, nor are you likely to be on a PowerPC machine running OS X.
Alp Toker
Comment 5
2007-07-02 17:44:49 PDT
yahoo.com works properly using the gdk port/GdkLauncher TOT.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug