RESOLVED FIXED 13407
[GDK] Fix font support in Gdk port
https://bugs.webkit.org/show_bug.cgi?id=13407
Summary [GDK] Fix font support in Gdk port
Alp Toker
Reported 2007-04-19 11:37:30 PDT
Patch attached for review.
Attachments
Fix page-specified fonts in gdk port (3.77 KB, patch)
2007-04-19 11:38 PDT, Alp Toker
mrowe: review+
Alp Toker
Comment 1 2007-04-19 11:38:45 PDT
Created attachment 14092 [details] Fix page-specified fonts in gdk port
Mark Rowe (bdash)
Comment 2 2007-04-20 00:07:39 PDT
Comment on attachment 14092 [details] Fix page-specified fonts in gdk port Keep in mind that we prefer C++-style casts over the C-style casts. It looks like the "assert" on "pattern" will only detect an out-of-memory condition, which is a runtime error and as such not appropriate for an assertion. r=me, I'll address those two nits when I land the change.
Mark Rowe (bdash)
Comment 3 2007-04-20 00:29:26 PDT
Landed in r20968.
Note You need to log in before you can comment on or make changes to this bug.