Bug 13407 - [GDK] Fix font support in Gdk port
Summary: [GDK] Fix font support in Gdk port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-19 11:37 PDT by Alp Toker
Modified: 2007-04-20 00:29 PDT (History)
0 users

See Also:

Attachments
Fix page-specified fonts in gdk port (3.77 KB, patch)
2007-04-19 11:38 PDT, Alp Toker 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-04-19 11:37:30 PDT 
Patch attached for review.
Comment 1 Alp Toker 2007-04-19 11:38:45 PDT 
Created attachment 14092 [details]
Fix page-specified fonts in gdk port
Comment 2 Mark Rowe (bdash) 2007-04-20 00:07:39 PDT 
Comment on attachment 14092 [details]
Fix page-specified fonts in gdk port

Keep in mind that we prefer C++-style casts over the C-style casts.  It looks like the "assert" on "pattern" will only detect an out-of-memory condition, which is a runtime error and as such not appropriate for an assertion.

r=me, I'll address those two nits when I land the change.
Comment 3 Mark Rowe (bdash) 2007-04-20 00:29:26 PDT 
Landed in r20968.