Bug 13398 - [GDK] Bring the port up to date
Summary: [GDK] Bring the port up to date
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-18 13:19 PDT by Alp Toker
Modified: 2007-04-18 18:07 PDT (History)
0 users

See Also:


Attachments
gdk port build fixes (3.52 KB, patch)
2007-04-18 13:21 PDT, Alp Toker
sam: review+
Details | Formatted Diff | Diff
gdk port build fixes (take two, with whitespace fixes) (3.52 KB, patch)
2007-04-18 16:52 PDT, Alp Toker
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-04-18 13:19:32 PDT
Patch attached for review.
Comment 1 Alp Toker 2007-04-18 13:21:25 PDT
Created attachment 14080 [details]
gdk port build fixes
Comment 2 Sam Weinig 2007-04-18 14:05:07 PDT
Comment on attachment 14080 [details]
gdk port build fixes

This seems fine except for 2 nit picks.  First, there are a couple tabs in the ChangeLog that should be removed before landing.  Second, there should be a space after the "return 0;" here:

+WebCore::Page* ChromeClientGdk::createModalDialog(Frame*, const FrameLoadRequest&) { notImplementedGdk(); return 0;}

Otherwise, r=me.
Comment 3 Alp Toker 2007-04-18 16:52:07 PDT
Created attachment 14082 [details]
gdk port build fixes (take two, with whitespace fixes)
Comment 4 Mark Rowe (bdash) 2007-04-18 18:07:40 PDT
Landed in r20939.