Bug 13391 - REGRESSION (r18819): Incomplete repaint of button text
Summary: REGRESSION (r18819): Incomplete repaint of button text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2007-04-18 06:43 PDT by mitz
Modified: 2007-04-21 22:50 PDT (History)
1 user (show)

See Also:


Attachments
Test case (208 bytes, text/html)
2007-04-18 06:44 PDT, mitz
no flags Details
Just ignore lightweight clip in repaint rect computation (39.58 KB, patch)
2007-04-21 08:53 PDT, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-04-18 06:43:57 PDT
See the attached test case.
Comment 1 mitz 2007-04-18 06:44:30 PDT
Created attachment 14073 [details]
Test case
Comment 2 mitz 2007-04-18 06:45:18 PDT
This bug affects the Web Inspector (at least on trunk).
Comment 3 mitz 2007-04-18 07:44:48 PDT
Corrected the revision range of the regression. The later changes merely made the issue visible in the inspector.
Comment 4 mitz 2007-04-18 08:27:34 PDT
This bug is a regression from Safari 2.0.4 since it also affects <button>. The regression was caused by <http://trac.webkit.org/projects/webkit/changeset/18819>.

The RenderBox::computeAbsoluteRepaintRect() logic for the hasControlClip() case is very strange - it doesn't look at the container o at all. I think it should intersect with o's controlClipRect(). However, in the case of this bug, the controlClipRect() is invalid since the container is in mid-layout (exactly the same problem discussed in the comments for the hasOverflowClip() case).
Comment 5 mitz 2007-04-21 08:53:02 PDT
Created attachment 14122 [details]
Just ignore lightweight clip in repaint rect computation

I think it's okay for now to just ignore the clip. Typically the contents don't overflow the control anyway, so this shouldn't cause successive repainting (for popups and listboxes, the contents are completely controlled by the engine).
Comment 6 Darin Adler 2007-04-21 10:15:56 PDT
Comment on attachment 14122 [details]
Just ignore lightweight clip in repaint rect computation

r=me; seems OK to ignore the clipping when repainting
Comment 7 Sam Weinig 2007-04-21 20:58:55 PDT
Landed in r21002.
Comment 8 Dave Hyatt 2007-04-21 22:11:03 PDT
Please file a followup bug to track the FIXME added to the code.
Comment 9 mitz 2007-04-21 22:50:40 PDT
(In reply to comment #8)
> Please file a followup bug to track the FIXME added to the code.
> 

Bug 13443.