Bug 13364 – REGRESSION: frame base URL is incorrect (some pages are not found)

• Status: RESOLVED
• Resolution: FIXED
• Component: Frames

[William Björklund]

Some linked pages return "not found" errors, though they are loaded without problem in other browsers. For example, the "English" button in the top right corner returns a 404 in Webkit but not in Firefox. Clicking on "Artister" in the menu and then on any artist name in the left column also returns a 404.

[Alexey Proskuryakov]

URL in TOT WebKit: http://www.peaceandlove.nu/index.php?page=english
Correct URL: http://www.peaceandlove.nu/2007/index.php?page=english

Looks like this is caused by an incorrect calculation of frame base URL: 

<FRAME SRC="2007/index.php" NAME="contents" NORESIZE FRAMEBORDER="no">

[Alexey Proskuryakov]

*** Bug 13362 has been marked as a duplicate of this bug. ***

[Brady Eidson]

Turns out this bug is not related to 13362.  I regressed that bug to between 16068 and 16085.

Turns out this one works fine on 16085 but I can confirm its broken in current ToT.  I'm going to regress this one, and reopen 16085.

[Brady Eidson]

Nevermind, I lied, I got confused with my multiple copies of webkit lying around.  I think the original diagnosis was correct

[Brady Eidson]

I'd wager real money this was caused by http://trac.webkit.org/projects/webkit/changeset/16081

[Alexey Proskuryakov]

Created attachment 14135 [details]
reduced test case

[Darin Adler]

<rdar://problem/5153021>

[Brady Eidson]

Created attachment 15609 [details]
Proposed fix - don't overwrite the (base)url if it's non-empty

[Darin Adler]

Comment on attachment 15609 [details]
Proposed fix - don't overwrite the (base)url if it's non-empty

Nonexistent has an "e" in it, not an "a".

+        (WebCore::Document::open): Only set the url and baseURL in document.open if the are still empty or about:blank

"they are"

r=me

[Alexey Proskuryakov]

Landed by Brady in r24491.