Bug 13353 - REGRESSION (r20754-20766): Textarea does not resize when scrollbar is present
Summary: REGRESSION (r20754-20766): Textarea does not resize when scrollbar is present
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL: data:text/html,<textarea style="resiz...
Keywords: HasReduction, Regression
Depends on:
Blocks:
 
Reported: 2007-04-15 11:09 PDT by Matt Lilek
Modified: 2007-04-21 01:41 PDT (History)
2 users (show)

See Also:


Attachments
Fix overflow controls hit testing (45.67 KB, patch)
2007-04-20 09:18 PDT, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2007-04-15 11:09:32 PDT
Textareas will not resize if there's enough content for it to have a scrollbar.

Regressed between r20754 and r20766 with http://trac.webkit.org/projects/webkit/changeset/20761 and http://trac.webkit.org/projects/webkit/changeset/20766 looking like the only changes that could have caused it.
Comment 1 mitz 2007-04-20 09:18:21 PDT
Created attachment 14111 [details]
Fix overflow controls hit testing
Comment 2 Darin Adler 2007-04-20 10:01:37 PDT
Comment on attachment 14111 [details]
Fix overflow controls hit testing

Possible future improvement:

+        IntRect vBarRect(absBounds.right() - renderer()->borderRight() - m_vBar->width(), absBounds.y() + renderer()->borderTop(), m_vBar->width(), absBounds.height() - (renderer()->borderTop() + renderer()->borderBottom()) - (m_hBar ? m_hBar->height() : resizeControlSize));

This line is very long. Maybe use some additional local variables or a helper function. Same with h-bar.

r=me
Comment 3 Mark Rowe (bdash) 2007-04-21 01:41:00 PDT
Landed in r20995.